Closed Bug 293889 Opened 19 years ago Closed 15 years ago

Typing in "find as you type" freezes Firefox for a while on big webpages when search term is not found

Categories

(Toolkit :: Find Toolbar, defect)

Product:
Toolkit
Component:
Find Toolbar
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED DUPLICATE of bug 512643

People

(Reporter: marcin.kowalski, Unassigned)

References

(
URL
)

Details

(Keywords: perf) 

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl-PL; rv:1.7.7) Gecko/20050414 Firefox/1.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; pl-PL; rv:1.7.7) Gecko/20050414 Firefox/1.0.3

The problem appears on big web pages when full text search takes a lot of time.
The worst case is of course when search term is not found, which happens often
as FAYT is by definition incremental.

Reproducible: Always

Steps to Reproduce:
1. Go to the URL
2. Type emacstralalal in FAYT
3. Wait....


Actual Results:  
Whole browser goes to sleep :)

Expected Results:  
It's obvious that there's no need to do any search when user adds letters at the
beggining or the end of term that is not found during previosus search. There
would be dramatic time boost on long pages and there's no need to change search
algorithm used. Actual method is simply brute force.

It's annoying even on ~1.7Ggz PC.
Get this too Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050512 Firefox/1.0+
Status -> NEW

I first noticed this on the Acid2 Test page. Also sometimes, when you highlight
it, you still cannot see the text.

Ways to reproduce this with the given URL: View-Source: Scroll to the right
about 5 times. Notice that the page is very wide. Scroll up all the way from the
bottom to the top. Notice that nothing is seen.

Another way: Try and Find (FAYT) "data:image" (minus quotes.) Notice that the
text gets highlighted, but that it cannot be seen.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Pardon the bugspam, the above comment was for bug 293875. I can confirm this one
too though! A suggestion that might help slightly on some pages when FAYT-ing
quickly: Once a term is not found, don't search again when another letter is typed.
Severity: normal → minor
OS: Windows XP → All
Version: unspecified → Trunk
See bug 267885 (and its dupe bug 272742).
(In reply to comment #4)
> See bug 267885 (and its dupe bug 272742).

Anyway, it's not exactly the same because it doesn't involve search algorithm
itself. Hope linear search is not the case. Brrrr.
*** Bug 321892 has been marked as a duplicate of this bug. ***
Do you still see the problem in FF 1.5?

WFM with the URL on thinkpad T40 512MB - Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6  

(however, there is plenty of other odd, inconsistent behavior with FAYT)
Keywords: perf
Wayne: yes, this still is a problem with 2.0 nightlies and on trunk.
Blocks: 267885
OK, I see it also, but not 100% repeatable after first loading of the page.
I get it too whit Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.1) Gecko/20060918 Firefox/2.0 ID:2006091818 but it only hangs.
Product: Firefox → Toolkit
I can confirm it too.
I can add that FF freezes using FAYT on laaaarge pages even if the search term IS found and it also freezes if you click on a blank part of the page.
Of course it un-freezes after a minute or so.

I think this bug renders the FAYT feature useless, because when you need it the most (search on BIG pages), it doesn't work.
Jorge, what version of Firefox are you using? Can you try out the recent 3.1 beta? Some work has been done since Firefox 3.0 was released to improve the selection code and it may have at least helped this bug a bit.
I'm using 3.0.3.
I'll trry the beta and see what happens.
(probably most of my extensions won't work, though)
wow! nice improvement, 99% better, I'd say (except for the occasional "stutter", it works very good now).
Of course, 3/4 'of my extensions don't work now...
I still get this issue with Firefox 3.0.5. Has anything been done yet in attempt to fix it?
Try the 3.1 betas, the problem is 98% solved on those builds and they are very stable.
Sorry, I can't confirm. Open the example page http://www.gnu.org/software/emacs/manual/html_mono/emacs.html, and you'll see that the incremental search still freezes firefox when adding characters to a search string that already hadn't been found before.
Oh, and I tried it with Firefox 3.1 Beta 2 ;-)
works fine for me...
Note that bug 512643 fixes the problem with hanging after each keystroke, which is what many of the dups are about.
Depends on: 512643
What part of this bug does that patch not address? Doesn't affect actual find speed, I guess, but that doesn't seem to be what this bug is about.
The initial description of this is identical to bug 512643, so I'm duping it.
Status: NEW → RESOLVED
Closed: 15 years ago
No longer depends on: 512643
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.