293914 - [FIXr]:hover state remains when ancestor of the hover content is removed

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

See testcase coming up

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

The problem is that ContentRemoved is called only on the root of the subtree
being removed.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 183418 [details] [diff] [review]
Patch

Another simple :hover fix when the DOM is being mutated.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 183418 [details] [diff] [review]
Patch

a=asa

Comment 5

[Boris Zbarsky [:bzbarsky]]

Fixed

Comment 6

[Martijn Wargers (dead)]

Attachment: testcase2 :active

So shouldn't this also be fixed for :active?

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Yeah, it should

With this patch, we correctly take the text out of :active when the mouse is
released after the kid has been removed.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 184154 [details] [diff] [review]
Yeah, it should

>   if (aContent == mLastMouseOverElement) {
>+    // XXXbz since this is just a recursion check, do we really want
>+    // to null this out here?
>     mLastMouseOverElement = nsnull;

Please replace this comment with a reference to bug 292146 (I was thinking I
should have added one then), and r+sr=dbaron.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Actually, you should probably fix that one too.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase showing that the mouseout element needs fixing too

Comment 11

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix 'em all

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 184167 [details] [diff] [review]
Fix 'em all

requesting 1.8b2 approval for simple fix to more state handling when the DOM
mutates.

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 184167 [details] [diff] [review]
Fix 'em all

moving request out to b3. We're very nearly wrapped up on 1.8b2.

Comment 14

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 184167 [details] [diff] [review]
Fix 'em all

a=shaver

Comment 15

[Boris Zbarsky [:bzbarsky]]

Fixed for 1.8b3.