293937 - reloading URL by hitting enter in URL bar no longer clears form state

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

This is a regression from bug 274784 and its followups (such as bug 293135).  I
don't have any of the fast-back preferences changed from their defaults (i.e.,
it's disabled).

It used to be that changes to a form were cleared by going to the URL bar and
pressing enter (which is often a much cheaper operation than Shift-Reload, since
it uses what's in the cache).  This no longer works correctly.

Steps to reproduce:
 1. load bug 3000
 2. type some garbage in one of the text inputs
 3. click in URL bar
 4. press enter

Expected results:
 4. page reloads
 4. garbage is no longer present in text input

Actual results:
 4. page reloads
 4. garbage remains in text input

Works correctly in Linux Firefox 2005-05-04-09-trunk.
Buggy           in Linux Firefox 2005-05-11-11-trunk.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

(In reply to comment #0)
> This is a regression from bug 274784 and its followups (such as bug 293135).

I should have said "presumably".  I didn't actually test using backouts.

Comment 2

[Boris Zbarsky [:bzbarsky]]

The fix for bug 293588 should fix this....

Comment 3

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050512
Firefox/1.0+ ID:2005051214

WFM after the bug 293588 landed

tested with both
browser.sessionhistory.max_viewers = 0
browser.sessionhistory.max_viewers = 5

Comment 4

[Boris Zbarsky [:bzbarsky]]

David, whenever you get a chance to recheck, let me know whether you're still
seeing this?  I couldn't reproduce it reliably even in an unpatched build (got
it to happen once and that's it), but I'd expect this to be pretty timing-related...

Comment 5

[chris hofmann]

dbaron,  can you check and "+" for b3 if needed?

Comment 6

[Brian Ryner (not reading)]

Resolving FIXED on the assumption that 293588 took care of this.  I can't
reproduce it in my build.