Closed Bug 293938 Opened 20 years ago Closed 20 years ago

most popular and newest links don't include application

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect)

Product:
addons.mozilla.org Graveyard
Component:
Public Pages
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: geofforama, Assigned: geofforama)

References

(
URL
)

Details

Attachments

(1 file, 2 obsolete files)

replace & with &
3.38 KB, patch
cso
: first-review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.7) Gecko/20050421 Firefox/1.0.3 (Debian package 1.0.3-2)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.7) Gecko/20050421 Firefox/1.0.3 (Debian package 1.0.3-2)

The links "most popular" and "newest" on the extension pages don't include
application. So, on the firefox page if you click "most popular" it will take
you to a page listing Mozilla Suite extensions as opposed to firefox ones.

Solution is obviously to add a "&application=firefox" to the links for most
popular and newest.  This problem should also exist on the theme pages.

Reproducible: Always
Attached patch fixes this bug (obsolete) — — Splinter Review 

        Attachment #183430 -
        Flags: first-review?

    
    

    
  
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.8) Gecko/20050511
Firefox/1.0.4
Status: UNCONFIRMED → RESOLVED
Closed: 20 years ago
Resolution: --- → WORKSFORME

    
    

    
  
Ok, the links on the content, not the sidebar.  Why isn't it using uriparams
like the sidebar does
Status: RESOLVED → UNCONFIRMED
Resolution: WORKSFORME → ---

    
    

    
  

      
      
      
      

        Attached patch
          
          
        uses uriparams() (obsolete)
        — 
          — Splinter Review
      

    


  
this patch supercedes the old one

        Attachment #183435 -
        Flags: first-review?

    
  

        Attachment #183430 -
        Attachment is obsolete: true

        Attachment #183430 -
        Flags: first-review?

    
  

        Attachment #183435 -
        Flags: first-review? → first-review?(mike.morgan)

    
  
Assignee: Bugzilla-alanjstrBugs → geofforama
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: 1.0 → 2.0
Version: unspecified → 1.0

    
    

    
  
Comment on attachment 183435 [details] [diff] [review]
uses uriparams()

You should use &

        Attachment #183435 -
        Flags: first-review?(mike.morgan) → first-review-

    
    

    
  


  

        Attachment #183435 -
        Attachment is obsolete: true

        Attachment #183439 -
        Flags: first-review?

    
  

        Attachment #183439 -
        Flags: first-review? → first-review?(mike.morgan)

    
  

        Attachment #183439 -
        Flags: first-review?(mike.morgan) → first-review+

    
    

    
  
Fixed.

Checking in extensions/index.php;
/cvsroot/mozilla/webtools/update/extensions/index.php,v  <--  index.php
new revision: 1.9.2.8; previous revision: 1.9.2.7ndex.php themes/index.php
done
Checking in themes/index.php;
/cvsroot/mozilla/webtools/update/themes/index.php,v  <--  index.php
new revision: 1.7.2.9; previous revision: 1.7.2.8
done

Status: NEW → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
Target Milestone: 2.0 → 1.1
Product: addons.mozilla.org → addons.mozilla.org Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: