most popular and newest links don't include application

RESOLVED FIXED in 1.1

Status

addons.mozilla.org Graveyard
Public Pages
RESOLVED FIXED
13 years ago
2 years ago

People

(Reporter: Geoff Smith, Assigned: Geoff Smith)

Tracking

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

13 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.7) Gecko/20050421 Firefox/1.0.3 (Debian package 1.0.3-2)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.7) Gecko/20050421 Firefox/1.0.3 (Debian package 1.0.3-2)

The links "most popular" and "newest" on the extension pages don't include
application. So, on the firefox page if you click "most popular" it will take
you to a page listing Mozilla Suite extensions as opposed to firefox ones.

Solution is obviously to add a "&application=firefox" to the links for most
popular and newest.  This problem should also exist on the theme pages.

Reproducible: Always
(Assignee)

Comment 1

13 years ago
Created attachment 183430 [details] [diff] [review]
fixes this bug
Attachment #183430 - Flags: first-review?

Comment 2

13 years ago
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.8) Gecko/20050511
Firefox/1.0.4
Status: UNCONFIRMED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → WORKSFORME

Comment 3

13 years ago
Ok, the links on the content, not the sidebar.  Why isn't it using uriparams
like the sidebar does
Status: RESOLVED → UNCONFIRMED
Resolution: WORKSFORME → ---
(Assignee)

Comment 4

13 years ago
Created attachment 183435 [details] [diff] [review]
uses uriparams()

this patch supercedes the old one
Attachment #183435 - Flags: first-review?
(Assignee)

Updated

13 years ago
Attachment #183430 - Attachment is obsolete: true
Attachment #183430 - Flags: first-review?
(Assignee)

Updated

13 years ago
Attachment #183435 - Flags: first-review? → first-review?(mike.morgan)

Updated

13 years ago
Assignee: Bugzilla-alanjstrBugs → geofforama
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: 1.0 → 2.0
Version: unspecified → 1.0

Comment 5

13 years ago
Comment on attachment 183435 [details] [diff] [review]
uses uriparams()

You should use &
Attachment #183435 - Flags: first-review?(mike.morgan) → first-review-
(Assignee)

Comment 6

13 years ago
Created attachment 183439 [details] [diff] [review]
replace & with &
Attachment #183435 - Attachment is obsolete: true
Attachment #183439 - Flags: first-review?
(Assignee)

Updated

13 years ago
Attachment #183439 - Flags: first-review? → first-review?(mike.morgan)

Updated

13 years ago
Attachment #183439 - Flags: first-review?(mike.morgan) → first-review+

Comment 7

13 years ago
Fixed.

Checking in extensions/index.php;
/cvsroot/mozilla/webtools/update/extensions/index.php,v  <--  index.php
new revision: 1.9.2.8; previous revision: 1.9.2.7ndex.php themes/index.php
done
Checking in themes/index.php;
/cvsroot/mozilla/webtools/update/themes/index.php,v  <--  index.php
new revision: 1.7.2.9; previous revision: 1.7.2.8
done
Status: NEW → RESOLVED
Last Resolved: 13 years ago13 years ago
Resolution: --- → FIXED
Target Milestone: 2.0 → 1.1
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.