293954 - JPG association is hardcoded internally. Please support plug-ins to view JPG's

Status: RESOLVED EXPIRED

(Core Graveyard :: Plug-ins, enhancement)

Description

[Corey McDonald]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

Our company writes a program to embed sound into JPG images. We currently have
an IE plugin that manages image viewing and audio playback. We'd like to offer
support for our large customer base with Firefox as well, but we are unable to
create a plugin for .JPG files. This is because of a hard coded check within
firefox where it looks at the extension, and, if it sees .jpg, just displays the
image instead of checking first for an external plugin to handle the type. 

I double-checked to make sure it wasn't actually checking the data by changing
the extension on a valid image file and creating a plugin for that new extension.

Keep in mind that other manufacturers will want to create plug-ins for the file
extensions that you have hard coded in the product. 

Reproducible: Always

Steps to Reproduce:
1. Set FileExtents value in a plugin to jpg
2. Drop a breakpoint in the plugin to make sure it gets invoked
3. Drop a file with a .jpg extension (even if it isn't actually an image) and it
will not invoke the plug-in.
4. Repeat these steps with a random file extension (like ".ghk"). The plug-in
will be invoked regardless of the file contents (i.e. rename a valid jpg to have
.ghk on the end).

Comment 1

[Josh Birnbaum]

What if the file is sent with a content-disposition:attachment header, to
request that the browser prompt the user for what to do with the file?  Granted,
that's not very user friendly.

This has been asked before (eg bug 204422) but it's not clear to me how the bug
it's a dupe of relates.

Over to Core:File Handling

Comment 2

[OstGote!]

Try to use the pref plugin.override_internal_types with true. Does it work?

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

>This is because of a hard coded check within
>firefox where it looks at the extension, and, if it sees .jpg, just displays the
>image instead of checking first for an external plugin to handle the type. 

fwiw that description is not quite correct. what's correct is that firefox by
default never lets a plugin handle a type that the browser can handle
internally. there is no hardcoded check for .jpg (in fact, the reason for this
is, if I remember correctly, that PNG files were often handled by quicktime)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Note also bug 58554.

In general, I'm not sure what we can do here -- we really do want to render PNG
ourselves instead of having QuickTime trying to do it....

Comment 5

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 6

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.