293970 - new event dialog

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Stuart Parmenter]

the old event dialog is a total disaster...

Comment 1

[Stuart Parmenter]

Attachment: new dialog, js, css, hookups, etc

Comment 2

[Stuart Parmenter]

for alarms we're trying hard to make the common user cases fit well in the main
dialog without making the dialog huge.  The current thinking is to pre-fill a
menupopup with a couple default items such as "15 minutes before" and "1 hour
before" .  Also available will be "before" and "after" as well as "at" which
allow you to set more specific reminders.  we'll save a MRU of these in prefs
and use them to prefill the list later.

Comment 3

[Stuart Parmenter]

Attachment: updated patch to provide alarm ui

cleaned up a bit and added alarm UI so we can be
as-functional-as-with-the-old-dialog (ignoring broken things like attendees and
recurrence)

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 184022 [details] [diff] [review]
updated patch to provide alarm ui

>Index: base/content/calendar-event-dialog.xul
>===================================================================
...

>+
>+<dialog
>+  id="calendar-editwindow"
>+  title="Edit Event"
>+  buttons="accept,cancel"
>+  ondialogaccept="return onAccept();"
>+  ondialogcancel="return onCancel();"
>+  onload="onLoad()"
>+  persist="screenX screenY"
>+  xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">
>+
>+  <!-- Javascript includes -->
>+  <script type="application/x-javascript" src="chrome://calendar/content/calendar-event-dialog.js"/>
>+  <script type="application/x-javascript" src="chrome://calendar/content/calendarUtils.js"/>
>+
>+
>+  <vbox id="dialog-box" flex="1">
>+
>+<grid flex="1">
>+  <columns>
>+    <column/>
>+    <column flex="1"/>
>+  </columns>

So, this is a nit, but please fix the indentation here so that it reflects the
structure of the document (have the <grid> be indented bast the <vbox> indent).
 The indents are only 2 spaces, so it's not a lot of wasted space, and it makes
things much saner if you're using auto-indenting, since emacs actually parses
the document to figure out the current nesting level (as opposed to using
1+level-of-previous-block-start like it does with code).

r=vladimir

Comment 5

[Stuart Parmenter]

checked in and working