29406 - "now" as from date in query gives internal server error

Status: RESOLVED WORKSFORME

(Bugzilla :: Query/Bug List, defect, P3)

Description

[Jesse Ruderman]

I tried typing "now" into from date to get bugzilla to display all the bugs 
that were less than a day old, but apache gave me an 500 internal server error. 
Same thing happened when I typed "yesterday". (I had selected "bug creation" in 
the box next to the date fields; if nothing in this box is selected, I don't 
think bugzilla evaluates the dates.)

I don't know what language bugzilla works in, and I definately don't know perl, 
but that smells like a data-type error to me. And when users can generate data 
type errors, they might be able to do uglier things using the same field.

Comment 1

[Terry Weissman]

[e-mail] is the new owner of Bugzilla and Bonsai.  (For details,
see my posting in netscape.public.mozilla.webtools,
news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)

Comment 2

[Chris Yeh]

naw, it just bounces the invalid sql query. you can't can't corrupt the database 
this way.

Comment 3

[Jesse Ruderman]

Reopening from INVALID because the lack of a security hole doesn't make this a 
non-bug.  This bug probably deserves a WONTFIX, though.

Comment 4

[Matthew Tuck [:CodeMachine]]

This bug probably deserves a better user error.

Comment 5

[Stephan Niemz]

moving to real milestones...

Comment 6

[Dave Miller [:justdave]]

This doesn't belong in Future, either.  I don't like Software Errors being 
displayed to the users...  we should be able to fix it so it does something 
polite "Hey you, Don't do that!"

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

Mass moving to new product Bugzilla...

Comment 8

[Gervase Markham [:gerv]]

This now gives a better error, albeit one which is somewhat messed up because of
multipart/x-mixed-replace.

Gerv

Comment 9

[Jesse Ruderman]

I'm not getting an error now.  Instead, I'm getting back every bug that matches 
the rest of my query, so the field isn't restricting anything.

Comment 10

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 11

[Antonis Christofides]

I rewrote that part of the code while fixing bug 37749, and I knowingly made it
ignore "now" as from date. More on this in bug 37749 comment 56.

This bug deserves a summary change, say '"now" as from date in query is
ignored', but I'm not doing it because it should also involve a version change,
and I've not quite understood what we do with the version field in Bugzilla.

Comment 12

[Gervase Markham [:gerv]]

Antonios: Is this bug still a bug, then?

Gerv

Comment 13

[Antonis Christofides]

This is not a bug any more. There is no internal server error. There is a
related issue, namely that "now" is ignored in the "from" field; it has been
like this for some time now (for example, see comment 7), and the patch of bug
37749, which is a rewrite of that part of the code, deliberately reproduces this
behavior for reasons explained in bug 37749 comment 56. This related issue, if
anyone really cares, should be filed as a new bug.

I'd mark this bug RESOLVED, but I don't know what resolution to give, the bug
was neither fixed nor invalid nor worksforme, it just went away some unknown
time in the past (maybe when Date::Parse was introduced). FIXED is probably
closest to what happened, I'm letting the seniors decide.

Comment 14

[Gervase Markham [:gerv]]

Resolving WFM based on comments.

Gerv

Comment 15

[Dave Miller [:justdave]]

clearing milestone in WONTFIX/WORKSFORME/INVALID so it'll show up as untriaged
if it gets reopened.