294078 - Build failure in nsCalendarApp.cpp due to API change

Status: VERIFIED FIXED

(Calendar :: Internal Components, defect)

Description

[David G King]

This bug was filed due to suggestion at
https://bugzilla.mozilla.org/show_bug.cgi?id=293461#c19

Due to an API change in Bug #293461, Sunbird no longer builds :-

e:/mozilla/source/mozilla/calendar/sunbird/app/nsCalendarApp.cpp:57: error: brac
e-enclosed initializer used to initialize `const char*'
e:/mozilla/source/mozilla/calendar/sunbird/app/nsCalendarApp.cpp:57: error: inva
lid conversion from `const char*' to `PRUint32'
e:/mozilla/source/mozilla/calendar/sunbird/app/nsCalendarApp.cpp:57: error: cann
ot convert `const char*' to `nsILocalFile*' in initialization
e:/mozilla/source/mozilla/calendar/sunbird/app/nsCalendarApp.cpp:57: error: inva
lid conversion from `int' to `const char*'
make[4]: *** [nsCalendarApp.o] Error 1



Line 57 is part of the following, and I assume that
NS_XRE_ENABLE_EXTENSION_MANAGER is the problem part :-

48 static const nsXREAppData kAppData = {
49   "Mozilla",
50   "Sunbird",
51   NS_STRINGIFY(APP_VERSION),
52   NS_STRINGIFY(BUILD_ID),
53   // {718e30fb-e89b-41dd-9da7-e25a45638b28}
54   { 0x718e30fb, 0xe89b, 0x41dd, { 0x9d, 0xa7, 0xe2, 0x5a, 0x45, 0x63, 0x8b,
0x28 } },
55   "Copyright (c) 2004 mozilla.org",
56   NS_XRE_ENABLE_EXTENSION_MANAGER
57 };


See https://bugzilla.mozilla.org/show_bug.cgi?id=293461#c17 for suggested solution.

Comment 1

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Vlad's, if not a dupe of something.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Just checked in a fix for this; updated the structure.

Comment 3

[David G King]

My compile works. V'ing.

Thanks for the quick response.