294150 - 50% Ts regression since landing of bug 293461

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Steve England [:stevee]]

Beast startup times according to:
-
http://build-graphs.mozilla.org/graph/query.cgi?tbox=beast&testname=startup&autoscale=0&size=1.5&days=5&units=&ltype=&points=&avg=1

show a 50% increase in Ts. Judging by
-
http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox&hours=24&maxdate=1115939632&legend=0

it appears the cause of this regression was the landing of bug 293461
cc: Benjamin

Comment 1

[Mike Connor [:mconnor]]

Ts went up by more like 60-70% on beast (Win) and imola (Mac).

Benjamin, can you back this out or fix ASAP?  I'll back this out tonight if no
action has been taken, since we're possibly spinning 1.1a1 Monday.

Comment 2

[Benjamin Smedberg]

Hold off and talk to me this (Monday) morning... I'm debugging this now.

Comment 3

[Benjamin Smedberg]

This needs love for 1.1a, either the fix in bug 293548 or a backout of bug
293461... but a backout would be painful because other stuff has landed on top
of it.

Comment 4

[Asa Dotzler [:asa]]

Time is very short for 1.8b2/1.1a. If we're not gonna have a fairly safe fix
today, then let's back this out.

Comment 5

[Darin Fisher]

Asa: I'm planning on landing the patch for bug 293548, which will fix this bug.

Comment 6

[Darin Fisher]

My patch for bug 293548 is in, so I think we can mark this bug fixed.

Comment 7

[Darin Fisher]

reopening... beast Ts did not come down after the patch landed.

Comment 8

[Benjamin Smedberg]

Attachment: Remove silly "isFunctioning" test that always fails on new -createProfile builds

Comment 9

[Darin Fisher]

Ben mentioned that you should verify that the EM cleans up its datasource when
the "extensions" folder happens to have been deleted.  For example, just go and
manually delete that folder, and then verify that EM recovers from that
situation.  I believe it should since we scan install locations at startup to
determine the actual items and then compare that against the known items to
determine what needs to be installed, removed, or updated.

Comment 10

[Benjamin Smedberg]

Comment on attachment 183830 [details] [diff] [review]
Remove silly "isFunctioning" test that always fails on new -createProfile builds

Low-risk, high-reward.

Comment 11

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 183830 [details] [diff] [review]
Remove silly "isFunctioning" test that always fails on new -createProfile builds

a=shaver.

Comment 12

[Benjamin Smedberg]

Fixed on trunk for 1.1a1.

Comment 13

[Boris Zbarsky [:bzbarsky]]

*** Bug 294740 has been marked as a duplicate of this bug. ***