Closed
Bug 294192
Opened 19 years ago
Closed 19 years ago
[nit] Having prefs without label and help info with group == hidden still spams the console
Categories
(Other Applications :: ChatZilla, defect)
Other Applications
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
(Whiteboard: [cz-patch][cz-0.9.68.4])
Attachments
(1 file)
|
1.43 KB,
patch
|
samuel
:
review+
shaver
:
approval1.8b3+
|
Details | Diff | Splinter Review |
When starting ChatZilla with the console open, 4 warnings are given every time you start it: WARNING: !!! Preference without label: urls.list WARNING: Preference without help text: urls.list WARNING: !!! Preference without label: urls.display WARNING: Preference without help text: urls.display To fix those (and make a general fix), the pref manager should check whether group == 'hidden' before making these warnings. Patch coming up.
|
Assignee | |
Comment 1•19 years ago
|
||
This takes care of the warnings, and should still do so for any subsequent hidden prefs.
Attachment #183606 -
Flags: review?(samuel)
|
||
Updated•19 years ago
|
Severity: normal → trivial
Whiteboard: [cz-patch]
|
||
Updated•19 years ago
|
Attachment #183606 -
Flags: review?(samuel) → review+
|
|
Assignee | |
Comment 2•19 years ago
|
||
Comment on attachment 183606 [details] [diff] [review] Patch to take the group into account before spewing warnings Requesting approval for harmless CZ patches
Attachment #183606 -
Flags: approval1.8b3?
|
|
||
Updated•19 years ago
|
Whiteboard: [cz-patch] → [cz-patch][cz-0.9.68.4]
Comment on attachment 183606 [details] [diff] [review] Patch to take the group into account before spewing warnings a=shaver
Attachment #183606 -
Flags: approval1.8b3? → approval1.8b3+
|
|
||
Comment 4•19 years ago
|
||
Checked in -> FIXED.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•