294208 - FAYT shoudn't be blocked when a form button, checkbox or a radio element is focused

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect, P2)

Description

[Asaf Romano (gone)]

The findbar implementaion blocks fayt whenever an <input> element is focused,
this (also) includes buttons, radios and checkboxes which are a no-real-blocker
to fayt.

(FYI, it's a ff-only bug, the xpfe version seems to work fine ;) )

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[Asaf Romano (gone)]

Comment on attachment 183612 [details] [diff] [review]
patch

I should use the type property; thanks for pointing out, Gavin.

Comment 3

[Asaf Romano (gone)]

Attachment: v1.1

Comment 4

[Asaf Romano (gone)]

Checking in toolkit/components/typeaheadfind/content/findBar.js;
/cvsroot/mozilla/toolkit/components/typeaheadfind/content/findBar.js,v  <-- 
findBar.js
new revision: 1.12; previous revision: 1.11
done

Comment 5

[Boris Zbarsky [:bzbarsky]]

Er.. So this code changed from being wrong to being wrong.  How about checking
instanceof on the element instead of checking localname?  <input> doesn't mean
"HTML input" by any means.

Comment 6

[Mike Connor [:mconnor]]

well, wrong to less wrong....

but yeah, lets get a new patch doing the right thing....

Comment 7

[Asaf Romano (gone)]

Attachment: v2

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 185804 [details] [diff] [review]
v2

Looks ok, but maybe we should have a followup bug on having a saner way to do
this (eg when we get editable SVG ideally we wouldn't have to change this
code!)

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 185804 [details] [diff] [review]
v2

r=me with the indenting in the switch fixed.  Please do file the followup bz
suggested though.

Comment 10

[Asaf Romano (gone)]

will do.

Checking in findBar.js;
/cvsroot/mozilla/toolkit/components/typeaheadfind/content/findBar.js,v  <-- 
findBar.js
new revision: 1.13; previous revision: 1.12
done

Comment 11

[[e-mail]]

Comment on attachment 185804 [details] [diff] [review]
v2

>   var elt = document.commandDispatcher.focusedElement;
>   if (elt) {
>+    if (elt instanceof HTMLInputElement) {
>+      // block FAYT when an <input> textfield element is focused
>+      var inputType = elt.type;
>+      switch (inputType) {
>+       case "text":
>+       case "password":
>+       case "file":
>+         return false;
>+      }
>     }
File inputs don't actually take focus in the normal scheme of things. Instead
you'll find that the .focusedElement is either the text or the button. They may
be some way of giving the file input container the focus, but in that case I
doubt it should block FAYT.

An alternative way of checking for text/password inputs is to access the
.controllers property which returns null for other types of inputs.

I don't know if it would be possible to add the event listener to the system
event group where it would fire after the input (or whichever) and hopefully be
able to tell if the event had already been handled.