294256 - editable menulist can't display initial value which is not in the menupopup

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Peter Wilson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050510 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050510 Firefox/1.0+

A <menulist editable="true" disableautoselect="true" label="X"> fails to display
an initial label value which is not in the dropdown list. 



Reproducible: Always

Actual Results:  
The menulist input field is empty. 


The culprit seems to be in XBL file menulist.xml, property: selectedItem, 
lines 371-376

            if (!this.selectedInternal) {
              this.inputField.value = "";
              this.removeAttribute('value');
              this.removeAttribute('label');
              return val;
            }
This can not be correct. If no item is selected then the inputField value must 
remain unchanged, and should reflect the value set via the label/value
attributes, or entered by the user. 
There may be other resons for this code, but I have created a version with these
lines commented out and everything seems to work for my particular usage.

Comment 1

[Boris Zbarsky [:bzbarsky]]

That's not a bug in XBL, just in a _user_ of XBL...  This component is for bugs
about XBL itself not working right (as in, you write a binding, and it doesnt'
work as it should).

Comment 2

[[e-mail]]

Hmm... it looks to me as if we shouldn't be trying to set the initial selection
in an editable menulist. Instead, we should rely on the (optional) autoselect.

Comment 3

[Neil Deakin]

This was fixed by bug 333023

Comment 4

[[e-mail]]

(In reply to comment #3)
>This was fixed by bug 333023

In particular, this part of the diff, from setInitialSelection:

>-              else
>+              else if (!editable)
>                 this.selectedIndex = 0;