29427 - nspr doesn't know anything about "make distclean"

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P3)

Description

[Holger Schurig]

... and therefore the included nspr in Mozilla makes it impossible to use "make
distclean" there.


Cure:


Add
  distclean: clean
to nspr's Makefile.



(See also bug #24758)

Comment 1

[Wan-Teh Chang]

Reassigned the bug to myself.

Comment 2

[Wan-Teh Chang]

Attachment: Proposed patch.

Comment 3

[Wan-Teh Chang]

I propose that we make distclean a synonym of realclean/clobber_all
to simplify things.

Comment 4

[Daniel (Leaf) Nunes]

*** Bug 24658 has been marked as a duplicate of this bug. ***

Comment 5

[cls]

The patch looks good to me.   Is there any particular reason that you don't want
to build pr/tests by default?

Comment 6

[Wan-Teh Chang]

We used to build pr/tests by default.  The problem with
that is that as we add more and more tests, it's taking
a long time to build pr/tests.  So we removed pr/tests
from the DIRS list in the top-level makefile.

Comment 7

[Wan-Teh Chang]

The patch (attachment 6549 [details] [diff] [review]) has been checked in on the main trunk.

Comment 8

[Wan-Teh Chang]

Attachment: Patch to restore realclean/clobber_all to their original behavior.

Comment 9

[Wan-Teh Chang]

The previous change to make realclean/clobber_all the same
as distclean is causing problem elsewhere (Bugzilla bug #32467),
so I'm changing it back.

Checked in patch 7279 on the main trunk.
/cvsroot/mozilla/nsprpub/Makefile, revision 3.20
/cvsroot/mozilla/nsprpub/Makefile.in, revision 1.8
/cvsroot/mozilla/nsprpub/config/rules.mk, revision 3.28

So now NSPR has three kinds of clean targets, which
corresponds to the three standard clean targets of
GNU programs as follows:
NSPR                     GNU
clean/clobber            mostlyclean
realclean/clobber_all    clean
distclean                distclean

Note that "clean" means different things in
NSPR and GNU.

Comment 10

[Wan-Teh Chang]

The fix for this bug has been merged into the
NSPRPUB_CLIENT_BRANCH and NSPRPUB_RELEASE_4_0_BRANCH.