Closed
Bug 294286
Opened 19 years ago
Closed 9 days ago
cmdkey characters are shown as MacRoman characters in menu
Categories
(Core Graveyard :: Widget: Mac, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: stefanh, Unassigned)
References
Details
(Keywords: intl, l12y, platform-parity)
Attachments
(1 file)
1.32 KB,
patch
|
Details | Diff | Splinter Review |
Tested on recent FF trunk with Mac OS 10.3.9: It appears that the commandkey characters are not interpreted as Unicode characters in Firefox on Mac OS X. Using the Swedish characters "Ä", ie "Ä"(196) and "Ö", ie "Ö"(214) as commandkeys will produce the equivalent MacRoman characters in the menu: ƒ (196) and ÷ (214). The labels etc works fine. This is an issue for any localizer that, for instance, doesn't have easy access to [ and ] (on a Swedish keyboard you'll have to press Option+8 in order to produce a "[") biesi had an idea of the problem: <biesi> ok I'd say the bug is at http://lxr.mozilla.org/seamonkey/source/widget/src/mac/nsMenuX.cpp#272 <biesi> the ToCString there truncates the unicode value to a latin1 char I assume SetItemCmd interprets it in the system charset
Reporter | ||
Comment 1•19 years ago
|
||
Here's a test-patch to show the issue. Note that the labels works fine.
Reporter | ||
Comment 2•19 years ago
|
||
Ah, forgot to say that the shortcuts works, the issue is only with the displayed characters.
Don't put LXR links into bug descriptions. When the file changes, it doesn't make sense any more. Better to just copy/paste the line with some context and a file name.
Reporter | ||
Comment 4•18 years ago
|
||
The cocoa switch seems to have fixed this
Reporter | ||
Comment 5•16 years ago
|
||
This doesn't really block bug 306585. I originally made it block because I wanted to use those characters instead of being forced to use the non-working en-US ones (even if they would have worked, they're not really an option).
No longer blocks: 306585
Reporter | ||
Comment 6•16 years ago
|
||
This 1.8-only - the cocoa switch fixed this.
Version: Trunk → 1.8 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•