Closed Bug 294290 Opened 19 years ago Closed 19 years ago

Port patch from bug 225563 to toolkit (keyboard activation of <html:a> in an XUL page needs to prevent activation of the default "OK" button)

Categories

(Toolkit :: UI Widgets, defect, P1)

Product:
Toolkit
Component:
UI Widgets
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8beta2

People

(Reporter: Gavin, Assigned: Gavin)

References

Details

Attachments

(1 file)

Patch
5.62 KB, patch
neil
: first-review+
asa
: approval-aviary1.1a1+
Details | Diff | Splinter Review 
This is needed for the Reporter tool to work correctly in Firefox. It's a
straight port to toolkit, based on attachment 174683 [details] [diff] [review].

(picking bogus component, bug 287788 needs fixing)
Attached patch Patch — — Splinter Review 

        Attachment #183674 -
        Flags: first-review?(neil.parkwaycc.co.uk)
Priority: -- → P1
Summary: Port patch from bug 225563 to toolkit ( 	keyboard activation of <html:a> in an XUL page needs to prevent activation of the default "OK" button) → Port patch from bug 225563 to toolkit (keyboard activation of <html:a> in an XUL page needs to prevent activation of the default "OK" button)
QA Contact: xulrunner → nobody

    
    

    
  
Seems that we need some more components in the toolkit product.

    
    

    
  
I've asked timeless to look into fixing bug 287788.
Status: NEW → ASSIGNED
Whiteboard: [patch-r?]
Target Milestone: --- → mozilla1.8beta3

    
    

    
  
Comment on attachment 183674 [details] [diff] [review]
Patch

Looks as if you covered everything there.

        Attachment #183674 -
        Flags: first-review?(neil.parkwaycc.co.uk) → first-review+
Whiteboard: [patch-r?] → [patch-r+][checkin needed]

    
    

    
  
Comment on attachment 183674 [details] [diff] [review]
Patch

Don't know whether it's too late for 1.1a, worth a shot I guess. Fixes Reporter
bug  294262.

        Attachment #183674 -
        Flags: approval-aviary1.1a1?

    
    

    
  
Comment on attachment 183674 [details] [diff] [review]
Patch

a=asa

        Attachment #183674 -
        Flags: approval-aviary1.1a1? → approval-aviary1.1a1+

    
    

    
  
Gavin:  if you can land that when you get a chance, I'd appreciate it.

I already appreciate it.  Thanks for the patch.

    
    

    
  
I don't have CVS access, someone else will have to check it in. Mike Connor said
he could do it later, but if anyone else can land it before then feel free.

    
    

    
  
Checking in button.xml;
/cvsroot/mozilla/toolkit/content/widgets/button.xml,v  <--  button.xml
new revision: 1.9; previous revision: 1.8
done
Checking in dialog.xml;
/cvsroot/mozilla/toolkit/content/widgets/dialog.xml,v  <--  dialog.xml
new revision: 1.20; previous revision: 1.19
done
Checking in wizard.xml;
/cvsroot/mozilla/toolkit/content/widgets/wizard.xml,v  <--  wizard.xml
new revision: 1.21; previous revision: 1.20
done

Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [patch-r+][checkin needed]
Target Milestone: mozilla1.8beta3 → mozilla1.8beta2

    
  
Component: XULRunner → XUL Widgets

    
  
Depends on: 225563

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: