294290 - Port patch from bug 225563 to toolkit (keyboard activation of <html:a> in an XUL page needs to prevent activation of the default "OK" button)

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P1)

Description

[:Gavin Sharp [email: [e-mail]]]

This is needed for the Reporter tool to work correctly in Firefox. It's a
straight port to toolkit, based on attachment 174683 [details] [diff] [review].

(picking bogus component, bug 287788 needs fixing)

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: Patch

Comment 2

[Darin Fisher]

Seems that we need some more components in the toolkit product.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

I've asked timeless to look into fixing bug 287788.

Comment 4

[[e-mail]]

Comment on attachment 183674 [details] [diff] [review]
Patch

Looks as if you covered everything there.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 183674 [details] [diff] [review]
Patch

Don't know whether it's too late for 1.1a, worth a shot I guess. Fixes Reporter
bug  294262.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 183674 [details] [diff] [review]
Patch

a=asa

Comment 7

[Robert Accettura [:raccettura]]

Gavin:  if you can land that when you get a chance, I'd appreciate it.

I already appreciate it.  Thanks for the patch.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

I don't have CVS access, someone else will have to check it in. Mike Connor said
he could do it later, but if anyone else can land it before then feel free.

Comment 9

[Asaf Romano (gone)]

Checking in button.xml;
/cvsroot/mozilla/toolkit/content/widgets/button.xml,v  <--  button.xml
new revision: 1.9; previous revision: 1.8
done
Checking in dialog.xml;
/cvsroot/mozilla/toolkit/content/widgets/dialog.xml,v  <--  dialog.xml
new revision: 1.20; previous revision: 1.19
done
Checking in wizard.xml;
/cvsroot/mozilla/toolkit/content/widgets/wizard.xml,v  <--  wizard.xml
new revision: 1.21; previous revision: 1.20
done