294346 - Remove #ifdef MOZ_PHOENIX from Thunderbird-specific help files

Status: RESOLVED DUPLICATE of bug 292995

(SeaMonkey :: Help Viewer, defect)

Description

[Simon Paquet [:sipaq]]

The Qute theme is only used by Thunderbird, so all #ifdef MOZ_PHOENIX code
should go:

http://lxr.mozilla.org/seamonkey/source/toolkit/themes/qute/help/help.css#43
http://lxr.mozilla.org/seamonkey/source/toolkit/themes/qute/help/help.css#122
http://lxr.mozilla.org/seamonkey/source/toolkit/themes/qute/help/help.css#130

Comment 1

[Simon Paquet [:sipaq]]

Attachment: Patch v1

Comment 2

[Jeff Walden (gone starting June 8)]

Comment on attachment 183732 [details] [diff] [review]
Patch v1

I'm not sure what the point of this is, because the same problem exists in
non-Thunderbird-specific files (but in a non-ifdef form that at best looks
prettier).  Doing this just makes things look better without actually doing
anything.  Also, Thunderbird doesn't use this code yet anyway, so I can't see a
reason to accept changes that don't make a useful or substantial difference.

I'm taking a look at the base issues here, so with some luck we'll get some
real traction on this sometime soon.

Comment 3

[Simon Paquet [:sipaq]]

(In reply to comment #2)
> I'm not sure what the point of this is, because the same problem exists in
> non-Thunderbird-specific files (but in a non-ifdef form that at best looks
> prettier). Doing this just makes things look better without actually doing
> anything. Also, Thunderbird doesn't use this code yet anyway, so I can't see 
> a reason to accept changes that don't make a useful or substantial difference.

Sorry, Jeff I really don't understand the issue here. Sure, the visual benefit
of this is zero. This is a simple cleanup of unnecessary ifdefs.

So what are you telling me here? Do you think that these ifdefs are necessary
and the bug is therefore INVALID? Or do you think that this should be fixed in
another way? If yes, which way?

Comment 4

[Jeff Walden (gone starting June 8)]

(In reply to comment #3)
> Sorry, Jeff I really don't understand the issue here. Sure, the visual benefit
> of this is zero. This is a simple cleanup of unnecessary ifdefs.

The thing is, you're not changing any of the functionality that makes those
ifdefs needed, and to the best of my knowledge you'd be breaking the viewer for
anyone who might happen to be using it with a Qute theme.  (I don't know this
for sure, but I have a strong feeling that's what would happen.)

> So what are you telling me here? Do you think that these ifdefs are necessary
> and the bug is therefore INVALID? Or do you think that this should be fixed in
> another way? If yes, which way?

Yes, the ifdefs are necessary now.  No, they shouldn't be there.  In fact, after
bug 295817 is fixed we should be 95% of the way there, and I intend to complete
the last 5% for 1.1/1.8 - just wait a little longer and we'll be done.

Comment 5

[Jeff Walden (gone starting June 8)]

The issues this bug addresses were fixed in bug 268776, but as written this bug
is a duplicate of bug 292995.  Don't blindly expect qute's theming of the help
viewer to work correctly, tho - with no way to test it (and no reason to do so
as the file's not used by Thunderbird) I don't know for certain that the
styling's perfect.  It's close enough to fix later (if necessary) whenever
Thunderbird decides to get its act together and ship typeaheadfind.

*** This bug has been marked as a duplicate of 292995 ***