294368 - Wrong tense used in sentence in delete components / products

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Oscar Manuel Gómez Senovilla]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; es-ES; rv:1.7.8) Gecko/20050511
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; es-ES; rv:1.7.8) Gecko/20050511

In the URL specified, in line 150 (in 2.19.3 it's line 133), it uses a past
tense in the sentence "You could not even see the ...", where it should be a
future tense. I've been suggested "Additionally, you will no longer be able to
see the [% terms.bug %] history for this component"

Reproducible: Always

Comment 1

[Christian Reis]

Tiago, wanna do some pretty trivial stuff meanwhile? :-)

Comment 2

[Tiago Mello [:timello]]

Attachment: v1: simple change in the confirm-delete.html.tpl

Comment 3

[Christian Reis]

Comment on attachment 183754 [details] [diff] [review]
v1: simple change in the confirm-delete.html.tpl

No exclamation point please. With that, r=kiko

Comment 4

[Oscar Manuel Gómez Senovilla]

I've just found out that this is in admin/milestones/confirm-delete.html.tmpl,
too. I don't think a new bug is necessary, since it's exactly the same sentence
appearing twice (I hope there are no more ocurrences)

Comment 5

[Dave Miller [:justdave]]

sounds reasonable to me.  you can fix them both and consider the a+ inherited.

Comment 6

[Tiago Mello [:timello]]

Attachment: v2: adding the msg into admin/milestone/confirm-delete.html.tmpl

Comment 7

[Frédéric Buclin]

Comment on attachment 183768 [details] [diff] [review]
v2: adding the msg into admin/milestone/confirm-delete.html.tmpl

>--- template/en/default/admin/milestones/confirm-delete.html.tmpl	6 Apr 2005 00:19:55 -0000	1.2
>+++ template/en/default/admin/milestones/confirm-delete.html.tmpl	16 May 2005 22:16:28 -0000
>@@ -80,7 +80,8 @@
>     [% END %]
>     entered for this milestone! When you delete this milestone,
>     <b><blink>ALL</blink></b> stored [% terms.bugs %] will be reassigned to
>-    the default milestone of this product.
>+    the default milestone of this product. Additionally, you will no longer be
>+    able to see the [% terms.bug %] history for this milestone.
>   </td></tr>
>   </table>
> 

First, there is no need to add that the bug history will be removed as it's not
true. Second, you should fix that sentence in editproducts.cgi too.

Comment 8

[Oscar Manuel Gómez Senovilla]

In comment 4, I only took a look at 2.19.1, but this had been corrected in a
later version, so it doesn't apply and the very first ocurrence seems to be the
only target to be fixed.

Comment 9

[Tiago Mello [:timello]]

Attachment: v3: replacing the msg for delete product

Comment 10

[Christian Reis]

Why am I still seeing the exclamation marks -- Tiago, are you reading the
comments here?

Comment 11

[Tiago Mello [:timello]]

Attachment: v4: changing the msg

Comment 12

[Frédéric Buclin]

Comment on attachment 183773 [details] [diff] [review]
v4: changing the msg

r=LpSolit

Comment 13

[Frédéric Buclin]

Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.83; previous revision: 1.82
done
Checking in template/en/default/admin/components/confirm-delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/components/confirm-delete.html.tmpl,v
 <--  confirm-delete.html.tmpl
new revision: 1.2; previous revision: 1.1
done