Closed Bug 294402 Opened 19 years ago Closed 19 years ago

Change unnecessary assertions in nsParser.cpp to warnings

Categories

(Core :: DOM: HTML Parser, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: mrbkap, Assigned: mrbkap)

Details

Attachments

(1 file)

In bug 220542 comment 28, Brendan asked me to change the assertions that I added
in the patch to that bug into warnings if the code could handle them. At the
time, I didn't want to because they were firing at unexpected times (as well as
the expected ones). It looks like the patch in bug 284587 fixed the unexpected
assertions, so I'll attach a patch to change them into warnings.
Attached patch patch v1Splinter Review
This simple patch changes the assertions into warnings.
Attachment #183774 - Flags: review?(brendan)
Status: NEW → ASSIGNED
Comment on attachment 183774 [details] [diff] [review]
patch v1

r+a=me, looks good -- glad this got sorted out.

/be
Attachment #183774 - Flags: review?(brendan)
Attachment #183774 - Flags: review+
Attachment #183774 - Flags: approval1.8b2+
Attachment #183774 - Flags: superreview?(bzbarsky)
Comment on attachment 183774 [details] [diff] [review]
patch v1

>Index: src/nsParser.cpp
>+  if (!(mFlags & NS_PARSER_FLAG_PARSER_ENABLED)) {
>+    NS_WARNING("Don't call ContinueInterruptedParsing on a blocked parser.");
>+  }

Make this whole if #ifdef DEBUG.

sr=bzbarsky with that.
Attachment #183774 - Flags: superreview?(bzbarsky) → superreview+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: