294405 - First launch of application results in "usage" dialog being shown

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect, P1)

Description

[Darin Fisher]

First launch of application results in "usage" dialog being shown, and the
application doesn't show.  I have to re-run the xulrunner command line to
actually show my application files.  This is reproducible using the 'simple'
application.

Comment 1

[Darin Fisher]

This turns out to be a regression caused by the patch for bug 293461.  The
incrementing and decrementing of argv and argc respectively (in
nsXULRunnerApp.cpp) was causing the app restart logic to fail miserably.  I
removed that code, and everything works properly.  I think bsmedberg was trying
to avoid tickling the command line handling code, but my original solution for
that was to leverage the '--app' command line flag to encapsulate the
path-to-application.ini argument.  At any rate, the current code is just plain
broken :(

Comment 2

[Darin Fisher]

I suspect that this bug might lend some clues as to why we are seeing a major Ts
hit on beast.  It seems to me that startup without a profile should not require
a restart, yet as this bug exhibits, it now does.  I believe that the
tinderboxen usually start with a fresh profile, so they should be restarting as
well.

Comment 3

[Darin Fisher]

Attachment: v1 patch

This patch just restores the old code and adds a comment explaining in more
detail why the code is needed.

Comment 4

[Benjamin Smedberg]

Comment on attachment 183804 [details] [diff] [review]
v1 patch

ok. We might want to use an envvar instead. But this won't explain the Ts jump
for Firefox.

Comment 5

[Darin Fisher]

> ok. We might want to use an envvar instead.

Yeah, an envvar could be used.  I would still need to munge argv since the other
arguments specified on the command line would still need to be forwarded to
nsAppRunner.cpp.  I could probably just shift arguments down or something like
that.  Hrm..

Comment 6

[Darin Fisher]

fixed-on-trunk

i added a XXX comment about implementing this using an envvar.  i wanted to just
get the nightly builds working again.  i'll return with a better patch later.

Comment 7

[Darin Fisher]

*** Bug 294436 has been marked as a duplicate of this bug. ***