294464 - Esc key no longer halts canvas animation

Status: RESOLVED INVALID

(Core :: Graphics: Canvas2D, defect)

Description

[Jeff Walden [:Waldo]]

Back when canvas was new, the Escape key would halt it -- this is typical for
in-page animations.  Sometime recently a bugfix regressed this behavior,
although I don't know when.  (I use home builds which aren't built on any
regular schedule.)  I tried the 2005-05-11-11 build, which exhibited the
failure, but I didn't try any further back because right around that time was
when canvas got hooked up to the tinderboxen.  Stopping animated GIFs still
works with Esc.

Adding a few people to the CC list who might be able to fix this...

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

I'm pretty sure the escape key never did this... the canvas isn't animating like
images are -- you're just continuing to draw to the canvas from js timeouts.  So
there's no way to stop any "animation" without blocking all further paints to
the canvas, which doesn't make any sense.

Comment 2

[James Ross]

Doesn't Esc kill off JS timeouts these days? Hm, seems like it doesn't any more,
but I know it did recently...

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Ah, bz says the escape key did this for a few months (jan 31 through may 8), but
that change had to be backed out... see bug 292921.