294534 - Search result columns do not show sort order arrow indicators

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Karsten Düsterloh]

[current trunk build of about yesterday]

When searching the messages, the results are displayed in a threadtree below the
search terms, but the column headers do not show the sort order indicators...

Comment 1

[Mike Cowperthwaite]

I'm pretty sure I've seen this reported before, but I can't locate the bug.
It's true in the suite (trunk and 1.7.7) and in TB (trunk and 1.0.2).

Comment 2

[Wayne Mery (:wsmwk)]

Bug 248787, Bug 285224 related?

Comment 3

[Karsten Düsterloh]

Maybe, since the same overlay is involved. But those bugs are about the main window and disappearing indicators, this bug is about the search window never having shown them...

Comment 4

[Wayne Mery (:wsmwk)]

(In reply to mcow comment #1)
> I'm pretty sure I've seen this reported before, but I can't locate the bug.
> It's true in the suite (trunk and 1.7.7) and in TB (trunk and 1.0.2).

was supposedly fixed by Bug 240491 in 2004. so is this a regression? (Is this the bug you were looking for?)


might also be a problem with themes, eg Bug 58058, but I don't think so.

Comment 5

[Mike Cowperthwaite]

(In reply to comment #4)
> (In reply to mcow comment #1)
> > I'm pretty sure I've seen this reported before, but I can't locate the bug.
> > It's true in the suite (trunk and 1.7.7) and in TB (trunk and 1.0.2).
> 
> was supposedly fixed by Bug 240491 in 2004. so is this a regression?
> (Is this the bug you were looking for?)

Yes, I think that's the bug I meant.  Adding Neil to CC list, since he fixed 240491, altho I don't have an installed build from ~2004, so I can't answer the regression question.

Comment 6

[[e-mail]]

Attachment: Fix regression from bug 256688

I don't think I have to worry about groupedBySortUsingDummyRow() since search views are never threaded or grouped, right?

Comment 7

[David :Bienvenu]

if we're talking about advanced search (as opposed to quick search or a single folder virtual folder), then yes, you're right, they can't currently be grouped/threaded. But quick search results and single folder virtual folders can be threaded.

Comment 8

[David :Bienvenu]

Comment on attachment 215935 [details] [diff] [review]
Fix regression from bug 256688

does that affect your patch? search results can't be grouped (yet) but they can be threaded if you were threaded before you did your quick search.

Comment 9

[[e-mail]]

No, this patch (and, I hope, bug!) is specific to advanced search.

Comment 10

[Karsten Düsterloh]

Comment on attachment 215935 [details] [diff] [review]
Fix regression from bug 256688

>Index: threadPane.js
>===================================================================
>+  // persist the sort settings
>+  dbview.saveSortInfo();

This function doesn't exist, but without these two lines the patch works as intended.
r=me without those two lines.

Comment 11

[[e-mail]]

Attachment: Updated for review comments

Comment 12

[[e-mail]]

Fix checked in to the trunk.

Comment 13

[[e-mail]]

Fix checked in to the branch.

Comment 14

[Mike Cowperthwaite]

V with 3a1-0426, 2a1-0416, Win2K