294536 - [FIXr]SVG fill command in inline styles not obeyed when embedded in XUL

Status: RESOLVED FIXED

(Core :: XUL, defect, P2)

Description

[Dale Jordan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050510
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050510

The fill command in the following inline style for an svg:rect tag is ignored in
current mozilla-win32-svg-GDI builds.  It works in older builds circa 2004/08. 
The example I will attach is embedded in XUL.

<svg:rect x="220" y="400" width="10" height="32"
          style="stroke:black; stroke-width:2px; fill:red"/>


Reproducible: Always

Steps to Reproduce:
1. Load file style-bug.xul into the browser.
2.
3.

Actual Results:  
Two rectangles are shown, one filled with black and one filled with red.

Expected Results:  
Both rectangles should be filled with red.

Comment 1

[Dale Jordan]

Attachment: XUL file showing file problem

Comment 2

[Rob Adams]

This actually applies to anything in the "style" attribute of an SVG node.  The
style attribute is completely ignored, and gets set to empty.  If you set it
using a stylesheet or change it after the page is loaded, it does honor these
properties.

Someone with permission should update the summary.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

UL's creating nodes with a bogus-ish nodeinfo, so they have a null
ownerDocument and don't parse the style when the attributes are set on them. 
This just gets the nodeinfo right (and then when we insert the node we don't
have to give it a new nodeinfo).

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 184721 [details] [diff] [review]
Proposed patch

Requesting 1.8b3 approval; this makes XUL play a little nicer with non-XUL
elements.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Fixed.