294581 - Forgot to filter by operating system in Most Popular query

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Geoff Smith]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050517 Firefox/1.0.4 (Debian package 1.0.4-2)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050517 Firefox/1.0.4 (Debian package 1.0.4-2)

The "most popular" query on the main themes and extensions page does not use the
$OS variable that indicates what operating system the user is using.  This
variable is used to filter out uninstallable extensions on the list of newest
extensions and all the other listings including the one on showlist.php.

Problems this causes:
1. shows uninstallable extensions and themes to users of other OS's (particular
mac and linux users)
2. some extensions and themes can get lost because the top 10 and the top 11-20
are using different query criteria

Reproducible: Always

Comment 1

[Geoff Smith]

Attachment: small patch to fix this problem

This patch fixes the problem for both themes and extensions.

Comment 2

[Colin Ogilvie [:cso]]

Checking in extensions/index.php;
/cvsroot/mozilla/webtools/update/extensions/index.php,v  <--  index.php
new revision: 1.9.2.9; previous revision: 1.9.2.8
done
Checking in themes/index.php;
/cvsroot/mozilla/webtools/update/themes/index.php,v  <--  index.php
new revision: 1.7.2.10; previous revision: 1.7.2.9
done