294671 - Incorrect attachment name shows when trying to "save as"

Status: RESOLVED INCOMPLETE

(Thunderbird :: Message Reader UI, defect)

Description

[Marcia Knous [:marcia]]

Seen using version 1.0 (20041206). I thought I had filed this bug a while back
but have been seeing it consistently.

STR:

1.  Open a message that has an attachment.  Right click to save ("Save As") the
attachment to your desktop.
2.  Go to another message that has an attachment. Right click to save ("Save
As") the attachment.

Results: The wrong attachment comes up. In almost every instance, the last
attachment that I downloaded is showing instead of the current one I am trying
to download. Workaround is using either "open" or "save all" instead.

Comment 1

[Scott MacGregor]

do you see this in trunk builds? I'm pretty sure this was fixed in 1.1. 

Comment 2

[Marcia Knous [:marcia]]

Scott: I will check this on today's trunk build and report back. 

Comment 3

[Marcia Knous [:marcia]]

Using today's trunk build, I don't see this behavior. closing this one out.

Comment 4

[Marcia Knous [:marcia]]

reopening, i am seeing this on today's mac trunk build - version 1.0+ (20050519)

Will work on providing exact STR.

Comment 5

[Marcia Knous [:marcia]]

I am still seeing this behavior testing version 1.0.5 (20050709).

STR:

1.  Find a message that has an attachment.  
2.  Select the attachment and click "Save As"
3.  Confirm that the attachment is downloaded to the location you select.
4.  Pick another message that has an attachment and follow the same steps as above.
5.  Confirm that Thunderbird tries to download the previous attachment that you
selected in Step 2, and not the one in the current mail message.

Note that during this testing session I was using a fresh profile.  We need to
revisit whether this is still present on the trunk.

Comment 6

[Zach Lipton [:zach]]

This seems to be fixed on the trunk as I cannot reproduce on 20050711 with mac
trunk. 

Comment 7

[Marcia Knous [:marcia]]

Just to update, I still see this on Tbird RC2 build.

Comment 8

[John Dorner]

Just to update... This is still occuring in version 1.5.0.2 (20060308)

Comment 9

[Maurits]

Bug 366513 seems to be a dupe of this bug,

it still happens for me 
Mac OSX 10.4.8 Intel
version 2 beta 2 (20070116)

However it only happens when the attachment is a .ppt / .xls / .doc .pdf file, it doesnt happen with .jpg so I assume only attachments which can't be displayed inline.

Comment 10

[Scott MacGregor]

Moving off bugs that didn't make the deadline for Thunderbird 2. 

Comment 11

[Shon Vella]

I'm seeing this as well but am seeing it with .jpg as well. After playing with it for a little while it looks like it behaves properly if I left click the attachment (so it gets selected) and then right click to do Save as. If I just right click it doesn't get selected and still seems that the attachment in the previous message is the one that is selected. Hope that helps. 

Comment 12

[Maurits]

Thunderbird 2.0.0.16 ID:2008070710

I'm no(t/ longer) able to reproduce the bug.
If you select the attachment (As per comment 11) it does work.

If the attachment is not selected it still shows the previous selected attachment (nothing if just started).

I Suggest that no attachment name is shown if no attachment is selected in the active message.

Comment 13

[Shon Vella]

IMHO the way it should behave the way it behaves on other platforms which is that right click on the attachment selects it before popping up the menu.

Comment 14

[Wayne Mery (:wsmwk)]

Is this the same as bug 317699? Based on comment 5 and comment 9 is sounds like it is not the same.

(I didn't find this without "name" in the summary.)

Comment 15

[Shon Vella]

I'm pretty sure it's the same - or at least they both seem to describe exactly what I am seeing and described in comment 11.

Comment 16

[[e-mail]]

Confirming that this is still present on tb3. This could result in data loss if a user it at all careless.

For example, if the filename 123.jpg shows up when you are trying to save a photo, you might just rename it to my-mom.jpg, and hit save. You might then delete the message (since you saved the attachment), only to realize later that the thing you saved was an attachment from a different message.

This bug has been around a long time. I'm nominating for 3.1 block due to the data loss issues.

Comment 17

[Dan Mosedale (:dmosedale, :dmose)]

Agree that this is a rotten bug.  However, we've survived shipping it before, and since 3.1 is primarily focused on stuff that blocks users upgrading from Tb2, we'd do so again.  :-(

Comment 18

[[e-mail]]

Ugh. Frown-face indeed. Is there a way to get this on the radar then for a future version or something? How are bugs prioritized for TB?

Comment 19

[Dan Mosedale (:dmosedale, :dmose)]

It's got the (newly-created, unversioned) wanted-thunderbird+ flag set on it to help keep it on the radar.

Comment 20

[Bartosz]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.7) Gecko/20100111 Lightning/1.0b1 Thunderbird/3.0.1

similar problem occurs now. Saved attachment loses its extension but only after renaming.

Comment 21

[Thomas D. (:thomas8)]

I suspect that this might have been fixed somewhere along the way when the attachment pane was reworked by Bug 630759.

I could not reproduce this bug following steps in comment 5.
However, I don't fully understand the Actual Results reported in this bug.
Does deletion of messages play a part in this?

Mike Lissner, Marcia (Reporter), could you confirm if this bug still exists?

WADA, could this be one of those bugs where AutoCompact messes with the internal message offset?
Is it possible that user opens "save as" dialogue, spending time to think about new file name, then during that pause autocompact changes message offset, then user confirms "save as" and TB actually saves the attachment of another message which now has the offset of old message?

(In reply to Mike Lissner from comment #16)
> Confirming that this is still present on tb3. This could result in data loss
> if a user it at all careless.
> 
> For example, if the filename 123.jpg shows up when you are trying to save a
> photo, you might just rename it to my-mom.jpg, and hit save. You might then
> delete the message (since you saved the attachment), only to realize later
> that the thing you saved was an attachment from a different message.
> 
> This bug has been around a long time. I'm nominating for 3.1 block due to
> the data loss issues.

Comment 22

[Thomas D. (:thomas8)]

(In reply to Bartosz from comment #20)
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.7) Gecko/20100111
> Lightning/1.0b1 Thunderbird/3.0.1
> 
> similar problem occurs now. Saved attachment loses its extension but only
> after renaming.

Bartosz, that's not this bug, that's bug 414865.

But the current summary of this bug 294671 is confusing because it's similar to bug 414865, but it does not seem to match the Actual Results described in comment 5 (or maybe I don't understand comment 5, or it's incomplete).

Comment 23

[Thomas D. (:thomas8)]

(In reply to Marcia Knous [:marcia - use needinfo] from comment #5)
> I am still seeing this behavior testing version 1.0.5 (20050709).
> 
> STR:
> 
> 1.  Find a message that has an attachment.  
Let's call it msg1 with attachment1 [details] [diff] [review].foo
> 2.  Select the attachment and click "Save As"
When "saving as", do I rename attachment1 [details] [diff] [review].foo e.g. to become myfile.foo?
> 3.  Confirm that the attachment is downloaded to the location you select.
So attachment1 [details] [diff] [review].foo has been successfully downloaded
> 4.  Pick another message that has an attachment and follow the same steps as
> above.
So from msg2, I select attachment2 [details] [diff] [review].bar, then "Save as" from context menu...
Do I rename it while saving?
> 5.  Confirm that Thunderbird tries to download the previous attachment that
> you
> selected in Step 2, and not the one in the current mail message.

So does it re-download attachment1 [details] [diff] [review].foo (from unrelated msg1), and saves it under the wrong name of attachment2 [details] [diff] [review].bar?

So per actual result of this bug, I would end up having 2 identical files containing the content of attachment1 [details] [diff] [review].foo, but one is (wrongly) named attachment2 [details] [diff] [review].bar, and the real content of attachment2 [details] [diff] [review].bar has been saved nowhere?

Comment 24

[Thomas D. (:thomas8)]

(In reply to Thomas D. from comment #23)
> (In reply to Marcia Knous [:marcia - use needinfo] from comment #5)
> > I am still seeing this behavior testing version 1.0.5 (20050709).
> > 
> > STR:
> > 
> > 1.  Find a message that has an attachment.  
> Let's call it msg1 with attachment_1.foo
> > 2.  Select the attachment and click "Save As"
> When "saving as", do I rename attachment_1.foo
> e.g. to become myfile.foo?
> > 3.  Confirm that the attachment is downloaded to the location you select.
> So attachment_1.foo has been successfully
> downloaded
> > 4.  Pick another message that has an attachment and follow the same steps as
> > above.
> So from msg2, I select attachment_2.bar, then
> "Save as" from context menu...
> Do I rename it while saving?
> > 5.  Confirm that Thunderbird tries to download the previous attachment that
> > you
> > selected in Step 2, and not the one in the current mail message.
> 
> So does it re-download attachment_1.foo (from
> unrelated msg1), and saves it under the wrong name of attachment_2.bar?
> 
> So per actual result of this bug, I would end up having 2 identical files
> containing the content of attachment_1.foo, but
> one is (wrongly) named attachment_2.bar, and
> the real content of attachment_2.bar has been
> saved nowhere?

Or when I select attachment_2.bar from msg2, then "save as", the dialogue wrongly suggests attachment_1.foo as default file name, so I end up overwriting the already downloaded attachment_1.foo with the file content of attachment_2.bar, i.e. I end up with only 1 file wrongly named attachment_1.foo (but having content of attachment_2.bar)?

Comment 25

[Thomas D. (:thomas8)]

(In reply to Thomas D. from comment #24)
> Or when I select attachment_2.bar from msg2, then "save as", the dialogue
> wrongly suggests attachment_1.foo as default file name, so I end up
> overwriting the already downloaded attachment_1.foo with the file content of
> attachment_2.bar, i.e. I end up with only 1 file wrongly named
> attachment_1.foo (but having content of attachment_2.bar)?

Iow, is this a duplicate of Bug 317699, which was probably fixed by or around Bug 630759?

Comment 26

[Thomas D. (:thomas8)]

(In reply to Thomas D. from comment #25)
> (In reply to Thomas D. from comment #24)
> Iow, is this a duplicate of Bug 317699, which was probably fixed by or
> around Bug 630759?

Right-click selection issues similar to Bug 317699 (of which this might be a dupe) were also reported elsewhere, and all gone:

Bug 533921 was fixed in 2010-05.
Bug 372956 was probably fixed by bug 630759 (2011-08), or at least it was seen any more (wfm) as of 2011-09.

Comment 27

[Phoenix]

Resolved per whiteboard