294675 - Improve favicon loading code

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect, P3)

Description

[Simon Fraser [no longer active]]

The site icon code currently has some problems:
1. you lose all the icons every time you crash (since they are in the standard
   disk cache, which gets invalidated on crash)
2. it doesn't cache NSImages, so that 100 bookmarks to the same site will
instantiate 100 NSImages (worse with history)
3. it doesn't contain logic to deal with favicons specified via <link> elements.

We need a generic API that says "give me the image for this url" that takes all
this into account. This needs a flag to say if it should hit the network, and
some  notification mechanism to say when an image for a url becomes available.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

For reference, point 3 is the only one with an existing bug, bug 162893.

Comment 2

[Simon Fraser [no longer active]]

I added an NSImage cache, so item 2) is fixed, and 3) is fixed via bug 162893.
However, issues remain:
We don't eagerly load the site icon images from the cache, because this causes a
lot of disk activity, and, in the case of history menu items, causes submenus to
fail to display for some reason (overflow of Carbon Event queue?). This means
that we still can't reliably say "give me the site icon for this URL" at any
time, so we still don't show correct site icons in the History menus until the
icon gets loaded by another means. So I'm keeping this bug open for now.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Simon, does the new favicon cache fix comment 0 point 1 and/or comment 2?  See also bug 304001 (which might be what you mention in comment 2).

Comment 4

[Simon Fraser [no longer active]]

The favicon cache fixes 1 and 2, yes. So I'd say this is fixed!