294732 - Inconsistency of field name for bookmark in main BM window and Bookmark's Info panel

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Marcello Testi]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:0.9.4.1) Gecko/2002 - Netscape 6.2, Mac OS X
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:0.9.4.1) Gecko/2002 - Netscape 6.2, Mac OS X

In the Bookmark Manager main window the column identifying the bookmark is
called "Title". If you Get Info on the bookmark, the field that was "Title" in
the bookmarks list, now is called "Name".

Reproducible: Always

Comment 1

[Jasper]

Confirming and taking the bug.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

The Info panel is a really nasty nib; I looked at it for something else.  Right
now both the bookmark and folder views are side-by-side and one is "magically
hidden".  Wevah said they really should be separate panels dynamically swapped
in (or something like that).  But that's not necessary for fixing *this* bug....

I think we should change "Name" in the Info panel to "Title" to keep
consistency.  In the Manager, you're getting actual page titles in History, so
it's the appropriate label.  It makes sense to keep it the same in Bookmarks and
then in the Info panel (also if we ever get an Info panel for History, bug
299799, Title will be the right label to use).

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #2)
> The Info panel is a really nasty nib; I looked at it for something else.  Right
> now both the bookmark and folder views are side-by-side and one is "magically
> hidden".  Wevah said they really should be separate panels dynamically swapped
> in (or something like that).  But that's not necessary for fixing *this* bug....

We talked about that in bug 288979, btw.

Comment 4

[Samuel Sidler (old account; do not CC)]

Jasper, will you get to this for 1.0?

Comment 5

[Jasper]

Yes I will make it happen next week.

Comment 6

[Markus Amalthea Magnuson]

Attachment: Changes "Name" to "Title" in the bookmark info window

Here's a new .nib-file that changes "Name" to "Title" in the bookmark info window.

Comment 7

[Jasper]

Looked at the nib and looks good to me. R+

Comment 8

[Mike Pinkerton (not reading bugmail)]

have a patch, plussing to get on radar.

Comment 9

[Simon Fraser [no longer active]]

Checked into trunk and branch. I also tidied up the Visit Count panel.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 201359 [details]
Changes "Name" to "Title" in the bookmark info window

Removing review request on fixed bug.