294771 - An existing message window not working as expected.

Status: NEW

(SeaMonkey :: MailNews: Message Display, defect)

Description

[ashish agarwal]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040514
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040514

Edit->Preferences->Mails & News group->windows->An existing message window not
working as expected.

Reproducible: Always

Steps to Reproduce:
1. Bring up the Mozilla Browser.
2. Bring up Mail window by Clicking  on Mail Icon on Browser's Task bar.
3. Select Edit->preferences-> Mail and Newsgroups ->Window Settings->select
"When opening a message display them them in an existing window' .
4. One message window is already open. Go to the Thread window, select two
messages including the one that is already open and press Enter.

Actual Results:  
If two message windows of the same message are opened ,steps.. first open one
message window as per the test case and then select one more message along with
the message of whose message window you have already opened ....
more than one window is opened for the message whose message window was opened
earlier. 


Expected Results:  
Verify that a new message window  is opened only for the message for the one
which does not have an already opened message window , while the other message
window opened first remains intact (except in case of messages in Draft and
Templates folder where in new composition windows are opened)

Comment 1

[Rupesh]

Attachment: Patch

I guess, the OS may be changed to All. The provided patch resolves the problem.

Comment 2

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 3

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.

Comment 4

[Scott MacGregor]

Comment on attachment 184386 [details] [diff] [review]
Patch

this is a seamonkey specific change, Karsten should decide if he wants it or not I think.

Comment 5

[Karsten Düsterloh]

Comment on attachment 184386 [details] [diff] [review]
Patch

The main problem here is that it's pretty unclear what this preference mailnews.reuse_message_window should actually mean when opening multiple messages at once.

IMO, the behaviour should depend on:
- the state of mailnews.reuse_message_window
- the number of messages to open
- the number of open message windows already open

If reuse=false, open all requested messages in new windows.
If reuse=true, reuse as many of the existing windows as possible before opening new ones.

Currently, if we have two message windows open and request two new ones, we get them - even if reuse is true. Your patch improves the situation a bit since it opens one window less, but is still a step too short...


>Index: mailWindowOverlay.js
>===================================================================
>+  var msgNum=0;  

msgNum is rather non-descriptive, something like firstNewWindow etc. would be more clear.

>+  if (gWindowReuse  && MsgOpenSelectedMessageInExistingWindow())  
>+      if (numMessages == 1)
>+         return;
>+      else
>+         msgNum=1;

First, most of this file uses 2 space indent, and so should you.
Second, else after return is futile, just use brackets on the outer if.
(But this code will probably need to change anyway to cope with reusing multiple message windows.)

Comment 6

[Karsten Düsterloh]

Should probably good if the patch author gets bugmail... ;-)