294778 - Unable to create new accounts when requirelogin is on

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, defect)

Description

[Darren Bowles]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

I have set up a new 1.18.1 Bugzilla server, but no-one is allowed to create a
new account.

I have managed to get around this, by changing createaccount.cgi and commenting
out the BugZilla->login(); line


# Just in case someone already has an account, let them get the correct footer
# on an error message.  The user is logged out just before the account is
# actually created.
#Bugzilla->login();


Reproducible: Always

Steps to Reproduce:
1. From main screen, click New Account
2. Click create a new account


Actual Results:  
Nothing happened

Expected Results:  
I would expect the create a new account screen to appear

Comment 1

[Frédéric Buclin]

I cannot reproduce this bug using 2.18.1. I'm able to create a new account. I
received an email with my password in it and I could successfully use it to log
in. Marking WFM!

Darren, what do you mean by "Nothing happened"?

If you can give me more information, we could reopen the bug.

Comment 2

[Darren Bowles]

When I say that nothing happened, what I mean is I expected the screen to change
to the one where I enter an email address and real name, but this did not
happen; the screen did not change in any way.

One oddity of my installation is that we have several distinct bugzilla systems
running on the same linux server.

Comment 3

[Frédéric Buclin]

After having entered an email address and a name, you should get this screen:

Account Created


A new account, [e-mail], has been created and a randomly-generated
password has been e-mailed to that address.

When the e-mail arrives, log in here.

Comment 4

[Frédéric Buclin]

Oops sorry, you meant that the page to enter your email address does not
appear!? I was thinking about the next step already. ;)

Comment 5

[Darren Bowles]

Yes, that is correct.  The page that asks you to enter your email address and
real name does not appear.

Comment 6

[Frédéric Buclin]

Okay, maybe I got it! Darren, is your 'requirelogin' param turned on (see
editparams.cgi near the bottom of the page)?

If yes, the problem is that you need to be logged in in order to create an
account. This is clearly a bug! :)

Comment 7

[Marc Schumann [:Wurblzap]]

Reopening per comment 6.

Comment 8

[Frédéric Buclin]

Attachment: patch for 2.19.3, v1

Comment 9

[Frédéric Buclin]

Attachment: patch for 2.18.2, v1

Comment 10

[Marc Schumann [:Wurblzap]]

Comment on attachment 184002 [details] [diff] [review]
patch for 2.19.3, v1

Tested; works.

>+use Bugzilla::Constants;

Nit: this should be up where use Bugzilla::User lives.

Comment 11

[Marc Schumann [:Wurblzap]]

Comment on attachment 184003 [details] [diff] [review]
patch for 2.18.2, v1

Same nit here. Can be fixed on checkin, I'd say.

Comment 12

[Frédéric Buclin]

Attachment: patch for 2.19.3, v2

Nit fixed

Comment 13

[Frédéric Buclin]

Attachment: patch for 2.18.2, v2

Comment 14

[Darren Bowles]

Yes, requirelogin is on.

I'll apply the path and let you know how I get on.

Comment 15

[Darren Bowles]

Patch works great, thanks.

Comment 16

[Frédéric Buclin]

Tip:

Checking in createaccount.cgi;
/cvsroot/mozilla/webtools/bugzilla/createaccount.cgi,v  <--  createaccount.cgi
new revision: 1.39; previous revision: 1.38
done

2.18.1:

Checking in createaccount.cgi;
/cvsroot/mozilla/webtools/bugzilla/createaccount.cgi,v  <--  createaccount.cgi
new revision: 1.33.2.2; previous revision: 1.33.2.1
done

Comment 17

[Frédéric Buclin]

*** Bug 303070 has been marked as a duplicate of this bug. ***