294784 - crash on unpaired restore()

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Hixie (not reading bugmail)]

restore(); lineWidth;

...crashes if you don't have a save().

Comment 1

[Stuart Parmenter]

Attachment: keep track of saves/restores so we can avoid crashing...

i'm just adding some code to check and see if savecount > 0 before calling
cairo_restore since it doesn't do _any_ checking internally and will crash if
you call it before calling save...

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 184006 [details] [diff] [review]
keep track of saves/restores so we can avoid crashing...

Yeah, works for me.. I think this is actually fixed in CVS cairo as well
(tracking the state stack), but we should take this bandaid for now.

If the saveStack is == 0, we might want to just destroy mCairo and create it
again to reset the bits, but not necessary until we figure out what the deal is
with CVS cairo.

Comment 3

[Mike Shaver (:shaver emeritus)]

Comment on attachment 184006 [details] [diff] [review]
keep track of saves/restores so we can avoid crashing...

a=shaver, crashing sucks.

Comment 4

[Stuart Parmenter]

checked in fix