294802 - admin/table.html.tmpl do not replace all %%some-col-name%% in contentlink

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[u197037]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050217
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050217

Construction of:
[% FOREACH m = link_uri.match('%%(.+?)%%'); %]
does not iterate through all the %%blah-blah-blah%% templates if more than one
template is used.
Think of
contentlink="url.cgi?param1=%%one%%&param2=%%two%%&param3=%%one%%" -
only %%one%%'s are replaced.

Reproducible: Always

Steps to Reproduce:
1. change any content link in admin/components/*.tmpl in the manner described in
'Details'
2.
3.

Actual Results:  
Supposing %%one%% should be replaced with 'one' and %%two%% with 'two':
url.cgi?param1=one&param2=%%two%%&param3=one


Expected Results:  
url.cgi?param1=one&param2=two&param3=one

The patch is attached

Comment 1

[u197037]

Attachment: patch, solving the problem

Just add a cycle to parse each instance of %%blah-blah-blah%%

Comment 2

[u197037]

Attachment: patch, solving the problem

Just add a cycle to parse each instance of %%blah-blah-blah%%

Comment 3

[Max Kanat-Alexander]

Dennis, you might want to look at the Reviewer List and pick an appropriate
specific reviewer:

http://www.bugzila.org/docs/reviewer-list.html

Comment 4

[u197037]

Comment on attachment 184009 [details] [diff] [review]
patch, solving the problem

Remove a duplicate patch - I've double pressed submit button...

Comment 5

[Joel Peshkin]

Comment on attachment 184010 [details] [diff] [review]
patch, solving the problem

2 things...
1) runtest.sh fails because there is a tab on the while line.  You must use
spaces and follow the 2-space/level indent rule.

2) Do you have a way of preventing an infinite loop if there is a %%word%% in a
replacement value??  [It is far fetched, but timeless would try this]

Comment 6

[Joel Peshkin]

By the way, I tried just changing the original code to use....

[% FOREACH m = link_uri.match('(?:%%(.+?)%%.*?)+'); %]

but I did not get it working.  It seems like an easier way, but I might be
missing something obvious.

Comment 7

[u197037]

Attachment: patch with fixed indenting (no tabs)

Comment 8

[u197037]

(In reply to comment #5)
> (From update of attachment 184010 [details] [diff] [review] [edit])
> 2 things...
> 1) runtest.sh fails because there is a tab on the while line.  You must use
> spaces and follow the 2-space/level indent rule.
Oops... should configure my VIm... Fixed

> 2) Do you have a way of preventing an infinite loop if there is a %%word%% in a
> replacement value??  [It is far fetched, but timeless would try this]
Yes, I also thought of this. But [% FILTER url_quote %] do that already (it just
makes it '%25%25word%25%25').

(In reply to comment #6)
> By the way, I tried just changing the original code to use....
> 
> [% FOREACH m = link_uri.match('(?:%%(.+?)%%.*?)+'); %]
> 
> but I did not get it working.  It seems like an easier way, but I might be
> missing something obvious.
I'm unable to find a correct regexp to do that. Afraid, It's impossible.

Comment 9

[Joel Peshkin]

Comment on attachment 184311 [details] [diff] [review]
patch with fixed indenting (no tabs)

looks good, r=joel

Comment 10

[Joel Peshkin]

Checked in for Dennis:

Checking in template/en/default/admin/table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/table.html.tmpl,v
<--  table.html.tmpl
new revision: 1.5; previous revision: 1.4
done