Closed
Bug 294816
Opened 19 years ago
Closed 19 years ago
Plugins can't define stringbundles for their preferences, which throws warnings when the plugin is loaded
Categories
(Other Applications :: ChatZilla, defect)
Other Applications
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
(Whiteboard: [cz-0.9.69])
Attachments
(1 file, 1 obsolete file)
2.40 KB,
patch
|
bugzilla-mozilla-20000923
:
review+
shaver
:
approval1.8b3+
|
Details | Diff | Splinter Review |
cz: WARNING: !!! Preference without label: PreferenceNameHere cz: WARNING: Preference without help text: PreferenceNameHere Is thrown for each and every pref, because plugins are unable(*) to define help or label information for their prefs. Plugins should be given the opportunity to define a stringbundle for their preferences the same way they can for commands - by adding a stringBundle property to the array of prefs / commands. This should allow plugin developers to define stringbundles in order to get rid of the warnings. (*) Hacks are possible, but rather bizarre, and hard to read / debug. Thanks to Silver, anyway, for coming up with one :-)
Assignee | ||
Comment 1•19 years ago
|
||
Makes the enabled pref hidden, so no warnings are thrown anymore. The remaining prefs (as defined by the plugin itself) are up to itself, not to us.
Attachment #184033 -
Flags: review?(samuel)
Comment 2•19 years ago
|
||
Comment on attachment 184033 [details] [diff] [review] Patch to take special care of the enabled pref, and allow plugins to do the rest Please no. You only need the 1 line from the Command Manager!
Attachment #184033 -
Flags: review?(samuel) → review-
Comment 3•19 years ago
|
||
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/extensions/irc/js/lib/command-manager.js&mark=180,184,195#177
Assignee | ||
Comment 4•19 years ago
|
||
*blushes* Better patch.
Attachment #184033 -
Attachment is obsolete: true
Attachment #184038 -
Flags: review?(silver)
Comment 5•19 years ago
|
||
Comment on attachment 184038 [details] [diff] [review] Patch #2 Much nicer. :) r=silver
Attachment #184038 -
Flags: review?(silver) → review+
Assignee | ||
Updated•19 years ago
|
Attachment #184038 -
Flags: approval1.8b3?
Comment on attachment 184038 [details] [diff] [review] Patch #2 a=shaver
Attachment #184038 -
Flags: approval1.8b3? → approval1.8b3+
Comment 7•19 years ago
|
||
Checked in -> FIXED.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•18 years ago
|
Whiteboard: [cz-0.9.69]
You need to log in
before you can comment on or make changes to this bug.
Description
•