Plugins can't define stringbundles for their preferences, which throws warnings when the plugin is loaded

RESOLVED FIXED

Status

Other Applications
ChatZilla
RESOLVED FIXED
13 years ago
12 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cz-0.9.69])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

13 years ago
cz:   WARNING: !!! Preference without label: PreferenceNameHere
cz:   WARNING: Preference without help text: PreferenceNameHere

Is thrown for each and every pref, because plugins are unable(*) to define help
or label information for their prefs. Plugins should be given the opportunity to
define a stringbundle for their preferences the same way they can for commands -
by adding a stringBundle property to the array of prefs / commands. This should
allow plugin developers to define stringbundles in order to get rid of the warnings.



(*) Hacks are possible, but rather bizarre, and hard to read / debug. Thanks to
Silver, anyway, for coming up with one :-)
(Assignee)

Comment 1

13 years ago
Created attachment 184033 [details] [diff] [review]
Patch to take special care of the enabled pref, and allow plugins to do the rest

Makes the enabled pref hidden, so no warnings are thrown anymore. The remaining
prefs (as defined by the plugin itself) are up to itself, not to us.
Attachment #184033 - Flags: review?(samuel)
(Assignee)

Updated

13 years ago
Depends on: 294192

Comment 2

13 years ago
Comment on attachment 184033 [details] [diff] [review]
Patch to take special care of the enabled pref, and allow plugins to do the rest

Please no.

You only need the 1 line from the Command Manager!
Attachment #184033 - Flags: review?(samuel) → review-
(Assignee)

Comment 4

13 years ago
Created attachment 184038 [details] [diff] [review]
Patch #2

*blushes*

Better patch.
Attachment #184033 - Attachment is obsolete: true
Attachment #184038 - Flags: review?(silver)

Comment 5

13 years ago
Comment on attachment 184038 [details] [diff] [review]
Patch #2

Much nicer. :)

r=silver
Attachment #184038 - Flags: review?(silver) → review+
(Assignee)

Updated

13 years ago
Attachment #184038 - Flags: approval1.8b3?
Comment on attachment 184038 [details] [diff] [review]
Patch #2

a=shaver
Attachment #184038 - Flags: approval1.8b3? → approval1.8b3+

Comment 7

13 years ago
Checked in -> FIXED.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Updated

12 years ago
Whiteboard: [cz-0.9.69]
You need to log in before you can comment on or make changes to this bug.