294816 - Plugins can't define stringbundles for their preferences, which throws warnings when the plugin is loaded

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[:Gijs (out for now; he/him)]

cz:   WARNING: !!! Preference without label: PreferenceNameHere
cz:   WARNING: Preference without help text: PreferenceNameHere

Is thrown for each and every pref, because plugins are unable(*) to define help
or label information for their prefs. Plugins should be given the opportunity to
define a stringbundle for their preferences the same way they can for commands -
by adding a stringBundle property to the array of prefs / commands. This should
allow plugin developers to define stringbundles in order to get rid of the warnings.



(*) Hacks are possible, but rather bizarre, and hard to read / debug. Thanks to
Silver, anyway, for coming up with one :-)

Comment 1

[:Gijs (out for now; he/him)]

Attachment: Patch to take special care of the enabled pref, and allow plugins to do the rest

Makes the enabled pref hidden, so no warnings are thrown anymore. The remaining
prefs (as defined by the plugin itself) are up to itself, not to us.

Comment 2

[James Ross]

Comment on attachment 184033 [details] [diff] [review]
Patch to take special care of the enabled pref, and allow plugins to do the rest

Please no.

You only need the 1 line from the Command Manager!

Comment 3

[James Ross]

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/extensions/irc/js/lib/command-manager.js&mark=180,184,195#177

Comment 4

[:Gijs (out for now; he/him)]

Attachment: Patch #2

*blushes*

Better patch.

Comment 5

[James Ross]

Comment on attachment 184038 [details] [diff] [review]
Patch #2

Much nicer. :)

r=silver

Comment 6

[Mike Shaver (:shaver emeritus)]

Comment on attachment 184038 [details] [diff] [review]
Patch #2

a=shaver

Comment 7

[James Ross]

Checked in -> FIXED.