Closed Bug 294824 Opened 19 years ago Closed 16 years ago

Don't hardcode appname in the cancel message for News

Categories

(MailNews Core :: Networking, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b1

People

(Reporter: mcsmurf, Assigned: mkmelin)

Details

Attachments

(1 file, 1 obsolete file)

When you cancel a message, it always uses this as body text:
This message from cancelled from within Mozilla.
I think this should be replaced with the new app-name then. Patch coming up.
Attached patch Patch (obsolete) — Splinter Review
Attachment #184028 - Flags: review?(bienvenu)
Frank, patch won't apply as is, but should if line offsets are fixed, 4068 changed to 4098 for example.

good first bug for someone
Severity: normal → minor
QA Contact: grylchan → mailnews.networking
Summary: Don't hardcode appname in the cancel message → Don't hardcode appname in the cancel message for News
Whiteboard: [good first bug]
Comment on attachment 184028 [details] [diff] [review]
Patch

canceling review
Attachment #184028 - Flags: review?(bienvenu) → review-
Product: Core → MailNews Core
Actually I changed my mind about this :).
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → WONTFIX
Hrm, no wait, good first bug, let's reopen this (sorry for the spam).
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Assignee: bugzilla → nobody
Status: REOPENED → NEW
Attached patch proposed fixSplinter Review
Use brand full name in the msg. 
Also silence the following compiler complaints:

/opt/comm-central/src/mailnews/news/src/nsNNTPProtocol.cpp: In member function ‘PRInt32 nsNNTPProtocol::PasswordResponse()’:
/opt/comm-central/src/mailnews/news/src/nsNNTPProtocol.cpp:2830: warning: unused variable ‘rv’
/opt/comm-central/src/mailnews/news/src/nsNNTPProtocol.cpp: In member function ‘nsresult nsNNTPProtocol::GetNewsStringByID(PRInt32, PRUnichar**)’:
/opt/comm-central/src/mailnews/news/src/nsNNTPProtocol.cpp:3725: warning: deprecated conversion from string constant to ‘char*’
/opt/comm-central/src/mailnews/news/src/nsNNTPProtocol.cpp: In member function ‘nsresult nsNNTPProtocol::GetNewsStringByName(const char*, PRUnichar**)’:
/opt/comm-central/src/mailnews/news/src/nsNNTPProtocol.cpp:3761: warning: deprecated conversion from string constant to ‘char*’
/opt/comm-central/src/mailnews/news/src/nsNNTPProtocol.cpp: In member function ‘nsresult nsNNTPProtocol::SetupPartExtractorListener(nsIStreamListener*)’:
/opt/comm-central/src/mailnews/news/src/nsNNTPProtocol.cpp:714: warning: ‘convertData’ may be used uninitialized in this function
Assignee: nobody → mkmelin+mozilla
Attachment #184028 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #341737 - Flags: superreview?(bienvenu)
Attachment #341737 - Flags: review?(Pidgeot18)
Whiteboard: [good first bug]
Target Milestone: --- → Thunderbird 3.0b1
Comment on attachment 341737 [details] [diff] [review]
proposed fix

>diff --git a/mailnews/news/src/nsNNTPProtocol.cpp b/mailnews/news/src/nsNNTPProtocol.cpp
>--- a/mailnews/news/src/nsNNTPProtocol.cpp
>+++ b/mailnews/news/src/nsNNTPProtocol.cpp
>@@ -2826,30 +2821,28 @@ PRInt32 nsNNTPProtocol::AuthorizationRes
> PRInt32 nsNNTPProtocol::PasswordResponse()
> {
>-  nsresult rv = NS_OK;
>-
>   if (MK_NNTP_RESPONSE_AUTHINFO_OK == m_responseCode ||
>     MK_NNTP_RESPONSE_AUTHINFO_SIMPLE_OK == m_responseCode)
>   {
>     /* successful login */
> #ifdef HAVE_NNTP_EXTENSIONS
>     PRBool pushAuth;
>     /* If we're here because the host demanded authentication before we
>     * even sent a single command, then jump back to the beginning of everything
>     */
>-    rv = m_nntpServer->GetPushAuth(&pushAuth);
>+    nsresult rv = m_nntpServer->GetPushAuth(&pushAuth);

FWIW, it would probably be a good idea at some point to drop HAVE_NNTP_EXTENSIONS code altogether. Just not in this patch.
Attachment #341737 - Flags: review?(Pidgeot18) → review+
Comment on attachment 341737 [details] [diff] [review]
proposed fix

thx, Magnus.
Attachment #341737 - Flags: superreview?(bienvenu) → superreview+
changeset:   509:ed4149b48992
http://hg.mozilla.org/comm-central/rev/ed4149b48992

->FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: