Closed Bug 294847 Opened 20 years ago Closed 8 years ago

Option for make-jars.pl to compress result

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: Mook, Unassigned)

Details

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050519 Firefox/1.0+ Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050519 Firefox/1.0+ I'm using make-jars.pl to package my extension xpi and would like the ability to actually compress the result (instead of the current "-0" for chrome jars). Patch coming in a sec, adds a "-9" switch to make-jars.pl to enable compression. Does not change default behaviour (so if the new switch is left out it's exactly the same as it is now). Reproducible: Always Steps to Reproduce:
Attached patch Adds -9 switchSplinter Review
Perl newbie, please tell me if I did anything bad. Thanks.
Attachment #184054 - Flags: review?(benjamin)
Why? Performance of uncompressed JARs is significantly better than compressed JARs. Why can't you just compress the *extension* (XPI) with -9? That way it's a small download, but performs well at runtime.
I am compressing just the XPI with -9... It's just that I'm making the XPI with make-jars.pl too (so I can preprocess stuff like install.rdf). The .jar files themselves are still uncompressed, I'm just abusing the system to make XPIs for me too :) (At this point I still need to rename the result from .jar to .xpi, but that's a lot easier than rebuilding the functionality of make-jars.pl)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Product: Mozilla Application Suite → Core
Version: unspecified → Trunk
Attachment #184054 - Flags: review?(benjamin) → review+
Attachment #184054 - Flags: superreview?(cls)
Attachment #184054 - Flags: superreview?(cls) → superreview+
We've done plenty with JAR compression since this bug was last updated 12 years ago. This bug is no longer relevant.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: