294886 - "uncaught exception" in listbox.xml when right clicking on virtual folder and selecting properties

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Henrik Gemal]

when i right click on a virtual folder and select properties I get:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIListBoxObject.getItemAtIndex]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://global/content/bindings/listbox.xml :: getItemAtIndex :: line 468" 
data: no]

using latest nightly build of tbird

Comment 1

[Ian Neal]

This also happens in mailnews so probably nothing to do with frontend code

Comment 2

[[e-mail]]

Attachment: Proposed patch (Checked in)

This is a regression from bug 195224. The new code to handle more/less doesn't
enjoy the presetting of gTotalSearchTerms. Additionally the less0 wasn't
disabled when there was only one search term.

Comment 3

[Scott MacGregor]

Comment on attachment 184326 [details] [diff] [review]
Proposed patch (Checked in)

I didn't test the dialog from the virtual folder dialog at all when I made
those changes. Good catch.

Comment 4

[sairuh (rarely reading bugmail)]

ran into this while playing with virtual folders saved via quicksearch.

recipe (reminder to self when testing the fix):

1. in quicksearch type a string which yields results in the thread pane.
2. from quicksearch dropmenu, select "save search as a folder..."
3. in the resulting "new saved search folder" dialog, look at the criteria
listbox in the bottom half of the dialog.

expected: should see the criterion (or criteria) listed in the listbox.

actual results: no criteria listed at all, the listbox is blank.

this also occurs when creating a virtual folder via the Views dropmenu, as well
as when creating a virtual folder from the Search Messages dialog.

Comment 5

[Ian Neal]

Comment on attachment 184326 [details] [diff] [review]
Proposed patch (Checked in)

Requesting a= for straight forward regression fix

Comment 6

[Ian Neal]

Comment on attachment 184326 [details] [diff] [review]
Proposed patch (Checked in)

Checking in searchTermOverlay.js;
new revision: 1.40; previous revision: 1.39
done

Comment 7

[sairuh (rarely reading bugmail)]

I still see this when I select File > New > Saved Search. tested with
2005052505-trunk.

Comment 8

[sairuh (rarely reading bugmail)]

vrfy'ing fixed for the other cases.

spun off bug 295488 for the remaining issue, comment 7.