294908 - Date: on daylight saving time start day, hour between 02:00 and 02:59 decremented [summer time]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

on the morning daylight saving time starts (6 April 2003 in
US):

Times between 02:00 and 02:59 inclusive are decremented, falling *back* one
hour.  They should be incremented, springing *forward* one hour, since clocks
are set forward at 02:00 standard time to 03:00 daylight time. 

Reproducible: Always

Steps to Reproduce:
In on computer set to US timezone (say, US eastern time), 
in Javascript console, 
evaluate "new Date(2003,03,06,02,30,00)"
(month is zero-based, so this is 2003 April 6, 02:30:00)
Actual Results:  
Sun Apr 06 2003 01:30:00 GMT-0500 (Eastern Standard Time)
----------------^^

Expected Results:  
Sun Apr 06 2003 03:30:00 GMT-0500 (Eastern Standard Time)
----------------^^

Comment 1

[gekacheka]

Also occurs in 1.8b
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b) Gecko/20050217

blocks bug 170169 

Comment 2

[gekacheka]

Expected results should also be Daylight time

Expected Results:  
Sun Apr 06 2003 03:30:00 GMT-0400 (Eastern Daylight Time)
----------------^^           ^^            ^^^^^^^^

Comment 3

[Brendan Eich [:brendan]]

bc may want to keep patching jsdate.c, which would be fine with me!

/be

Comment 4

[Bob Clary [:bc] (inactive)]

I'm still holding out for review and approval of bug 58116!

Comment 5

[André Bargull [:anba]]

Fixed in https://hg.mozilla.org/mozilla-central/rev/b7ef07909cc4

Before:
new Date(2003,03,06,02,30,00).toString()
"Sun Apr 06 2003 02:30:00 GMT-0400 (Eastern Standard Time)"


After:
new Date(2003,03,06,02,30,00).toString()
"Sun Apr 06 2003 02:30:00 GMT-0400 (Eastern Daylight Time)"