294926 - middle-click on link gives autoscroll icon; does not open link

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[u88484]

When middle-clicking on a link the icon and scroll arrows for autoscroll appear
instead of opening the link in a new tab...regression

Comment 1

[David Harper]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050520
Firefox/1.0+

I can confirm this. Also Right-Click, then Open in new Tab doesn't work. I
expect this is related.

Comment 2

[Jaime Mitchell (use [e-mail] for email)]

*** Bug 294930 has been marked as a duplicate of this bug. ***

Comment 3

[Dave Townsend [:mossop]]

Without autoscroll enabled, middle click functions as normal.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050520
Firefox/1.0+ ID:2005052009

Comment 4

[Grayson Mixon (ColdFusion650)]

right click> open in new tab works for me. 14:41 build

Comment 5

[Brendan Eich [:brendan]]

This works for me with fixes checked in today, not yet in respins, for bug 281988.

/be

Comment 6

[Steve England [:stevee]]

Note: You have to have Tools > Options > Advanced > General > Use Auto-scroll
enabled to see the middle-clicking-a-link-not-working bug.

Comment 7

[Jaime Mitchell (use [e-mail] for email)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050520
Firefox/1.0+ ID:2005052013

Still broken, are there other fixes to go in or should this have been fixed in
this build.

Apologies if you meant that the fixes are still to be checked in.

-> Reopen in case it should be fixed by earlier checkins

Comment 8

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050520
Firefox/1.0+ ID:2005052014

With Tools > Options > Advanced > General > Use Auto-scroll ticked, middle
clicking on a link still pops the Auto-scroll icon rather than opening the link
in a new tab like it used to.

Comment 9

[Mike Connor [:mconnor]]

Yeah, fresh build from a 40 minute-old checkout shows the same thing here.

Comment 10

[Sébastien Auger]

very annoying bug indeed.

Comment 11

[Rick Tilson]

FYI. Using All-In-One Gestures 0.14.3 with "All-In-One autoscroll" set, this
doesn't happen. With "Native autoscroll" set, problem manifests.

Comment 12

[Andrew Schultz]

this hits linux too with the auto-scroll turned on

Comment 13

[Asaf Romano (gone)]

http://lxr.mozilla.org/seamonkey/source/browser/base/content/browser.js#4632

Comment 14

[Boris Zbarsky [:bzbarsky]]

The problem is that instanceof is returning false across the board for
XPCNativeWrappers.

Comment 15

[Tristor]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050521
Firefox/1.0+

Still shows up on the 21st's build.

Comment 16

[Brendan Eich [:brendan]]

Attachment: xpcshell testcase showing instanceof working for "non-system" scripts

Need an easy way to test "system" scripts.  If someone can make a reduced
testcase for Firefox, please lay it on this bug.

/be

Comment 17

[Boris Zbarsky [:bzbarsky]]

Attachment: "Minimal testcase"

Apply this, rebuild in browser/, start firefox, right-click on an HTML page.

instanceof isn't broken for Components.interfaces.nsIFoo because the relevant
hasInstance hook deals.

The problem here is that DOMJSClass_HasInstance does _not_ deal: it gets an
XPCNativeWrapper JSObject, gets its class, and tries to return a value based on
that, which naturally doesn't work.

I suppose we could manually get the wrapped JSObject here or something... Need
to expose a way to tell that we're dealing with an XPCNativeWrapper if we do
that.  And we might have to fix the various other hasInstance hooks too (eg
liveconnect,  maybe jsxml, etc).

Comment 18

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch per discussion with jst

Comment 19

[Johnny Stenback (:jst)]

Comment on attachment 184266 [details] [diff] [review]
Patch per discussion with jst

r+sr=jst

Comment 20

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 184266 [details] [diff] [review]
Patch per discussion with jst

Fixes instanceof regression with the new security stuff.

Comment 21

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 22

[Tristor]

(In reply to comment #21)
> Fixed.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050522
Firefox/1.0+

Verified Fixed in the latest hourly on WinXP

Comment 23

[Jaime Mitchell (use [e-mail] for email)]

*** Bug 294921 has been marked as a duplicate of this bug. ***