Closed
Bug 294957
Opened 20 years ago
Closed 20 years ago
Search Web for "[object XPCNativeWrapper ]" appears in right click context menu
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jaime.bugzilla, Unassigned)
References
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
2.84 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
brendan
:
approval1.8b2+
|
Details | Diff | Splinter Review |
3.55 KB,
patch
|
brendan
:
review+
bzbarsky
:
superreview+
brendan
:
approval1.8b2+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050520
Firefox/1.0+ ID:2005052010
Right click on page or link or image
Search Web for "[object XPCNativeWrapper ]" appears in right click context menu
appears as an option
Clicking performs a google search for [object XPCNativeWrapper ]
![]() |
||
Comment 1•20 years ago
|
||
Brendan, this is the toString issue we were talking about. The selection object
has a nontrivial toString() that we're messing with.
![]() |
||
Updated•20 years ago
|
Comment 2•20 years ago
|
||
This is a fix.
/be
Attachment #184132 -
Flags: superreview?(bzbarsky)
Attachment #184132 -
Flags: review?(bzbarsky)
Attachment #184132 -
Flags: approval1.8b2+
Updated•20 years ago
|
Attachment #184132 -
Attachment is obsolete: true
Attachment #184132 -
Flags: superreview?(bzbarsky)
Attachment #184132 -
Flags: review?(bzbarsky)
Attachment #184132 -
Flags: approval1.8b2+
Comment 3•20 years ago
|
||
Attachment #184134 -
Flags: superreview?(bzbarsky)
Attachment #184134 -
Flags: review?(bzbarsky)
Attachment #184134 -
Flags: approval1.8b2+
![]() |
||
Updated•20 years ago
|
Attachment #184134 -
Flags: superreview?(bzbarsky)
Attachment #184134 -
Flags: superreview+
Attachment #184134 -
Flags: review?(bzbarsky)
Attachment #184134 -
Flags: review+
Comment 4•20 years ago
|
||
Fixed.
/be
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
![]() |
||
Comment 5•20 years ago
|
||
So... this broke the stringifying of XPCNativeWrappers when the wrapped native
has its normal toString. I no longer see the "[XPCNativeWrapper ..." part.
I'll bet the xpconnect toString stuff is hooked in before Object.prototype.
This makes it pretty hard to debug things, since I can't tell when I'm actually
looking at a wrapper and when I'm not (see eg bug 294960 where stuff wasn't
being wrapped and it took me a while to notice).
Brendan, I'm reopening this to get it back on the radar. Sorry. :(
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 6•20 years ago
|
||
r+a=self, checking in.
/be
Attachment #184190 -
Flags: review+
Attachment #184190 -
Flags: approval1.8b2+
Comment 7•20 years ago
|
||
Fixed.
/be
Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
![]() |
||
Comment 8•20 years ago
|
||
Comment on attachment 184190 [details] [diff] [review]
fix for toString
I like. Thank you!
Attachment #184190 -
Flags: superreview+
![]() |
||
Comment 9•20 years ago
|
||
I filed bug 295151 on the one concern I have with this patch.
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•