294957 - Search Web for "[object XPCNativeWrapper ]" appears in right click context menu

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jaime Mitchell (use [e-mail] for email)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050520
Firefox/1.0+ ID:2005052010

Right click on page or link or image

Search Web for "[object XPCNativeWrapper ]" appears in right click context menu
appears as an option

Clicking performs a google search for [object XPCNativeWrapper ]

Comment 1

[Boris Zbarsky [:bzbarsky]]

Brendan, this is the toString issue we were talking about.  The selection object
has a nontrivial toString() that we're messing with.

Comment 2

[Brendan Eich [:brendan]]

Attachment: fix

This is a fix.

/be

Comment 3

[Brendan Eich [:brendan]]

Attachment: diff -w of better patch

Comment 4

[Brendan Eich [:brendan]]

Fixed.

/be

Comment 5

[Boris Zbarsky [:bzbarsky]]

So... this broke the stringifying of XPCNativeWrappers when the wrapped native
has its normal toString.  I no longer see the "[XPCNativeWrapper ..." part.

I'll bet the xpconnect toString stuff is hooked in before Object.prototype. 
This makes it pretty hard to debug things, since I can't tell when I'm actually
looking at a wrapper and when I'm not (see eg bug 294960 where stuff wasn't
being wrapped and it took me a while to notice).

Brendan, I'm reopening this to get it back on the radar.  Sorry.  :(

Comment 6

[Brendan Eich [:brendan]]

Attachment: fix for toString

r+a=self, checking in.

/be

Comment 7

[Brendan Eich [:brendan]]

Fixed.

/be

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 184190 [details] [diff] [review]
fix for toString

I like.  Thank you!

Comment 9

[Boris Zbarsky [:bzbarsky]]

I filed bug 295151 on the one concern I have with this patch.