294972 - Reporter's back/next buttons behaving badly

Status: RESOLVED FIXED

(Other Applications Graveyard :: Reporter, defect)

Description

[Ben Basson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050520 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050520 Firefox/1.0+

Bug 294808 ensures that the "I accept" checkbox is unchecked by default.
However, the "Next" button needs to be disabled by default. Currently, I can
ignore the policy and go straight to the next stage.

At the second stage, the "back" button is also broken. For cases where the user
has just accepted the privacy policy, I think the back button should be enabled.
For cases where the reporter starts up without the privacy policy being shown,
the button probably shouldn't be there at all on this screen.

Reproducible: Always

Comment 1

[Robert Accettura [:raccettura]]

Attachment: Patch

We shouldn't let the user go forward without agreeing (when the heck did that
break?)

As far as being able to go back to the	privacy policy agreement, I'd have to
disagree.  You can click on the link to go view the privacy policy again. 
There is a link right below the form.

Motion to disable canAdvance when we init the privacy page until the user
agrees to our privacy policy.

Comment 2

[Ben Basson]

> We shouldn't let the user go forward without agreeing (when the heck did that
> break?)

I'd guess it was enabled by default since the checkbox was also enabled by
default and when the checkbox got changed, the button didn't, but there could be
other factors since this isn't based on my reading of any code.

> You can click on the link to go view the privacy policy again. 
> There is a link right below the form.

Well, it's your department and it's not something that'll really bother me, but
it just seems like strange UI. Whenever I click "Next" I normally expect to be
able to click "Back". I was going to leave it, but someone else pointed it out
in the 20050521 builds thread.

Comment 3

[Asa Dotzler [:asa]]

Comment on attachment 184160 [details] [diff] [review]
Patch

a=asa

Comment 4

[Robert Accettura [:raccettura]]

Checking in extensions/reporter/resources/content/reporter/reportWizard.js;
/cvsroot/mozilla/extensions/reporter/resources/content/reporter/reportWizard.js,v
 <--  reportWizard.js
new revision: 1.15; previous revision: 1.14
done

Comment 5

[Robert Accettura [:raccettura]]

Checking in extensions/reporter/resources/content/reporter/reportWizard.js;
/cvsroot/mozilla/extensions/reporter/resources/content/reporter/reportWizard.js,v
 <--  reportWizard.js
new revision: 1.15; previous revision: 1.14
done