Closed Bug 295060 Opened 20 years ago Closed 20 years ago

NSS test cipher.sh doesn't run in some MKS shells

Categories

(NSS :: Test, defect, P2)

x86
Windows XP
defect

Tracking

(Not tracked)

RESOLVED FIXED
3.10.2

People

(Reporter: nelson, Assigned: nelson)

Details

Attachments

(1 file)

As reported in bug 193055, some versions of MKS shell have a problem
with the construct
  cat somefile | while read var1 var2 var3; do .....; done

The afflicted shells only read the first line of piped input.
The fix is to change all those constructs to instead look like this:
  while read var1 var2 var3; do .....; done < somefile

That has already been done to most, but not all, NSS test scripts.  
The shell scripts in nss/test/cipher need this treatment.  
Patch forthcoming.
Taking bug (I meant to assign it to myself)
Assignee: jason.m.reid → nelson
Priority: -- → P2
QA Contact: bishakhabanerjee → jason.m.reid
Target Milestone: --- → 3.10.1
Attached patch patch v1Splinter Review
Wan-Teh, please review.
Attachment #184197 - Flags: review?(wtchang)
Comment on attachment 184197 [details] [diff] [review]
patch v1

r=wtc.
Attachment #184197 - Flags: review?(wtchang) → review+
Thanks for the review Wah-Teh.

Checking in cipher.sh;       new revision: 1.9; previous revision: 1.8
Checking in performance.sh;  new revision: 1.3; previous revision: 1.2
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: 3.10.1 → 3.10.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: