295066 - Normal text on webpages can be drag and dropped into the bookmarks toolbar.

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Barbaros]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

when i choose some written by holding mouse button (highlight text) i can move
it to the bookmark toolbar and adress toolbar.When i move text to the adress bar
it goes into the adress that is written.
for example : when i highligt "mozilla" and move it to the adress button it
appears like www.sit"mozilla"ename.com.
when i move it to the bookmark toolbar it appears like a button

Reproducible: Always

Comment 1

[Anders Conbere]

This is by the intended function, and created that way by design.

Comment 2

[Anders Conbere]

looks like this needs more discussion , sorry

Comment 3

[Tristor]

(In reply to comment #1)
> This is by the intended function, and created that way by design.

I would agree as far the location bar having the ability to drag text into it,
but that is apparently broken in latest-trunk (regression and followup?), but I
think being able to create bookmarks on the bookmarks toolbar out of regular
text is silly and definitely not by design.  Let me try to write up a decent
report on this and see about where to stick this, and I will go ahead and
confirm it in a moment I guess...

Comment 4

[Tristor]

Let's concentrate on the dragging and dropping into the bookmarks toolbar, since
the other half of this bug report is already fixed on Trunk it seems (reporter,
in the future please file a seperate report for each issue).  Let's see if I
can't clean the report up a bit.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050521
Firefox/1.0+

Dragging normal text from a document into the bookmarks toolbar creates a
bookmark there.  This behavior is improper because normal text, by it's very
nature cannot be a valid bookmark.  The appropriate behavior would be to only
allow links to be dragged into the bookmarks toolbar, which is the current
behavior for the location bar, and seems to be more correct.


Steps to Reproduce:

1. Highlight some text somewhere on this page
2. Drag it into the bookmarks toolbar with the right mouse button
3. Try to open the bookmark by clicking on it, it is invalid.

Expected Results:

Normal text cannot be dragged into the bookmarks toolbar but links can be.

Actual Results:

Anything dragged into the bookmarks toolbar will create a bookmark.

Comment 5

[Tristor]

I am thinking this belongs in Firefox/Bookmarks since it is about the Bookmarks
Toolbar.  Jaime brought up a valid point in IRC about this bug.  I am incorrect
in saying that normal text bookmarks are invalid, as they trigger the behavior
for searching that is assigned to the URL/Location bar.  By default, it will do
a Google "I'm feeling lucky" search, or if you did one of the more popular
hacks, it will do a normal Google search.  Regardless, I don't think the correct
behavior for bookmark drag n drop is to have normal text be able to be dragged
into the toolbar.  I am going to go ahead and confirm this, I guess.

Comment 6

[Andrew Verner]

I can see why this is intended behavior.  If I type out a URL on a page (such as
http://www.google.com) and am too lazy to make it a link (or can't because I'm
typing it on a forum that disallows HTML, etc.), you can still add it to your
bookmarks by selecting it and dragging it to the toolbar.

Comment 7

[Marco Bonardo [:mak]]

WFM on current trunk
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20081215 Minefield/3.2a1pre