Closed Bug 29507 Opened 25 years ago Closed 24 years ago

clean up PresShell refcounting.

Categories

(Core :: Layout, defect, P3)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: waterson, Assigned: waterson)

Details

(Keywords: memory-leak, Whiteboard: fix ready)

Attachments

(1 file)

proposed changes
5.31 KB, patch
Details | Diff | Splinter Review 
While trying to track down the leak referred to in Bug 25364, I stumbled across
a couple places where a PresShell could potentially be leaked because of
control-flow problems. Since none of these actually *did* fix the leak, I'm not
going to try to check them in right now, but I want to attach a patch, etc. so
that I don't forget.

Also, the mRefCnt = 99 is no longer required in the PresShell's dtor, because
NS_IMPL_RELEASE now stabilizes each object's refcounts to one before calling the
dtor.
Status: NEW → ASSIGNED
Keywords: mlk
Whiteboard: fix ready
Target Milestone: M15
Attached patch proposed changes — — Splinter Review 

    
    

    
  
fixes checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED

    
    

    
  
Marking fixed per last comments.

Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: