295070 - nsConverterInputStream::Init returns nsnull in an nsresult method

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

49 NS_IMETHODIMP
 50 nsConverterInputStream::Init(nsIInputStream* aStream,
[...]
 62     if (NS_FAILED(rv)) return nsnull;

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

(it should return rv, just to be clear)

Comment 2

[Joshua Welderson]

Attachment: Proposed Patch

Requesting review.

Comment 3

[Simon Montagu :smontagu]

Comment on attachment 184867 [details] [diff] [review]
Proposed Patch

r=smontagu

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

you also need super-review... see http://www.mozilla.org/hacking/reviewers.html

Comment 5

[Joshua Welderson]

Comment on attachment 184867 [details] [diff] [review]
Proposed Patch

Done.  Is there anything else I should do?

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

well, once you have sr you need to ask for approval again (unless you want to
wait until we branch for 1.8), and then the patch can be checked in.

Comment 7

[Christopher Blizzard (:blizzard)]

Comment on attachment 184867 [details] [diff] [review]
Proposed Patch

I'm not doing reviews at the moment.  Please ask someone else on the sr list. 
Sorry!

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed on trunk

Checking in intl/uconv/src/nsConverterInputStream.cpp;
/cvsroot/mozilla/intl/uconv/src/nsConverterInputStream.cpp,v  <-- 
nsConverterInputStream.cpp
new revision: 1.16; previous revision: 1.15
done