295095 - Ctrl+Shift+letter treated as Ctrl+letter

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Ctrl+F, e
2. Ctrl+G a few times
3. Ctrl+Shift+G

Result: find next (as if I had pressed Ctrl+G again)
Expected: find previous

Regression window:
  works: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050520 Firefox/1.0+
  broken: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050521 Firefox/1.0+

Comment 1

[:Gavin Sharp [email: [e-mail]]]

This looks like a regression from bug 285161's patch.

Comment 2

[Andreas Grillenberger]

Bug confirmed on build 20050521 (Win) - the shift key isn't interpreted

Comment 3

[Ere Maijala (slow)]

Sigh. Maybe we need forced lowercase letters only if alt is pressed too. I'll
confirm this and create an appropriate patch.

Comment 4

[Ere Maijala (slow)]

Ugh, either I screwed up before or something has changed for better. It seems
we're expected to return a lowercase letter when ctrl or alt is down only if
shift isn't down. 

Comment 5

[Ere Maijala (slow)]

Attachment: Patch to fix the goof

Patch v1. Don't make the character lowercase if shift is pressed.

Comment 6

[Elmar Ludwig]

*** Bug 295206 has been marked as a duplicate of this bug. ***

Comment 7

[Dainis Jonitis]

FYI: I've made a platform independent fix for this in bug 295228.

Comment 8

[Ere Maijala (slow)]

Not really, this fix (or something similar) is still needed. 

Comment 9

[Ava3ar]

works for me, (as in expected)

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050523 Firefox/1.0+

Comment 10

[Daniel Veditz [:dveditz]]

Comment on attachment 184230 [details] [diff] [review]
Patch to fix the goof

r=dveditz

Comment 11

[Andrew Schultz]

*** Bug 295293 has been marked as a duplicate of this bug. ***

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 184230 [details] [diff] [review]
Patch to fix the goof

a=asa. Who can land this? Time is very short for 1.8b2/1.1a1

Comment 13

[Asa Dotzler [:asa]]

Timeless landed this for us. Thanks, Josh. Resolving.

Comment 14

[Bob Clary [:bc] (inactive)]

works for me in deer park alpha 1 as described in comment 0
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050524
Firefox/1.0+

Comment 15

[Asa Dotzler [:asa]]

Verified fixed using today's build on winXP and win2K.

Comment 16

[Justin Wood (:Callek)]

*** Bug 295092 has been marked as a duplicate of this bug. ***

Comment 17

[:Gavin Sharp [email: [e-mail]]]

*** Bug 295515 has been marked as a duplicate of this bug. ***

Comment 18

[[e-mail]]

Comment on attachment 184230 [details] [diff] [review]
Patch to fix the goof

>+        if (!mIsShiftDown 
Nit: trailing space

>             && NS_VK_A <= virtualKeyCode && virtualKeyCode <= NS_VK_Z) {
>           asciiKey += 0x20;
I might have mentioned it before, but I like |= 0x20, because then you don't
have to exclude the digits ;-)

>+  if (!mIsShiftDown && (saveIsAltDown || saveIsControlDown)) {
>     uniChar = towlower(uniChar);
>   }
Unfortunately this doesn't work for AltGr+A with Caps Lock on. I thought
perhaps you meant to use mIsAltDown || mIsControlDown but I couldn't get that
to work either...