295121 - Secure Site indicator not shown when secure site loaded in new tab

Status: VERIFIED FIXED

(Firefox :: Security, defect)

Description

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050522
Firefox/1.0+ ID:2005052203

1. New Profile, start firefox. Observe the firefox homepage.
2. Enter https://bugzilla.mozilla.org/show_bug.cgi?id=281988 into the URL bar
and hit alt-enter to open the bugzilla bug page in a new tab.
3. Observe the bugzilla bug page has no secure site warnings.
4. Click on the firefox homepage tab.
5. Click back on the bugzilla bug page tab. Note now that the URL bar indicates
that the page is secure.

From IRC discussions, regression date is:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-05-19+16%3A00%3A00&maxdate=2005-05-19+22%3A40%3A00&cvsroot=%2Fcvsroot

Comment 1

[Peter van der Woude [:Peter6]]

confirming
Open secure site in new tab from bookmarks has the same result

Comment 2

[Peter van der Woude [:Peter6]]

nailed it to the "Minute"

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-05-19+21%3A20%3A00&maxdate=2005-05-19+22%3A38%3A00&cvsroot=%2Fcvsroot

Comment 3

[Boris Zbarsky [:bzbarsky]]

Um... The code that was added in the checkin mentioned in comment 2 has since
been removed...

The fix for bug 294815 is a much more likely candidate for this.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Yeah, backing out bug 294815 makes this better.

Comment 5

[Mike Connor [:mconnor]]

Attachment: patch

I can't believe I didn't hit that case in testing.  Or in code reading.  Good
thing I spent the weekend so far catching up on sleep.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 184315 [details] [diff] [review]
patch

a=asa

Comment 7

[Daniel Veditz [:dveditz]]

*** Bug 295263 has been marked as a duplicate of this bug. ***

Comment 8

[Daniel Veditz [:dveditz]]

This was checked in, is it fixed?

Comment 9

[Steve England [:stevee]]

Fixed for me
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050523
Firefox/1.0+ ID:2005052311

Comment 10

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050523
Firefox/1.0+ ID:2005052311

testcase WFM

Comment 11

[Tracy Walker [:tracy]]

verified with Windows trunk build 2005-05-23-12-trunk