295140 - remember previous online state doesn't work

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

"remember previous online state" doesn't work for me.
I've set this option but when I leave Thunderbird in offline mode and startup
again it's again in online state.

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

I think the interesting pref is:
user_pref("offline.startup_state", 0); 

This is the setting in prefs.js if "remember previous online state" is used and
Thunderbird was offline before quitting.

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

after further investigation I found that the pref network.online will not be set
to "false" if the offline state is reached.

Comment 3

[Wolfgang Rosenauer [:wolfiR]]

OK, it seems that aviary-branch has very much changes which are missing from the
trunk version to fix this.
I think someone familiar with the code should merge both versions of
mailnews/extensions/offline-startup/js/offlineStartup.js

And this really blocks aviary1.1 IMHO.

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

I think this is a MAJOR one.

Comment 5

[David :Bienvenu]

It looks like Neil's changes in rev 1.9 of offlineStartup.js, for bug 240898
might be responsible. We don't seem to get a profile-approve-change notification
when shutting down thunderbird, so we never remember the offline/online state.
We used to just remember it when the online/offline state changed, as long as we
weren't starting up.  I don't know if Seamonkey always generates this
notification, but Thunderbird doesn't seem to get it.

Comment 6

[David :Bienvenu]

Attachment: proposed fix

this fixes it for thunderbird - not sure about seamonkey. Does this look OK,
Neil?

Comment 7

[Scott MacGregor]

Comment on attachment 188969 [details] [diff] [review]
proposed fix

looks good to me.