Closed Bug 29516 Opened 25 years ago Closed 25 years ago

replacing copyright symbol to "(c)" in the search data file comment section to reduce unnecessary assertion

Categories

(SeaMonkey :: Search, defect, P3)

Product:
SeaMonkey
Component:
Search
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: ftang, Assigned: ftang)

Details

(Whiteboard: [PDT+] ETA 2/28) 

I hit a lot of assertion when I trun on the nsString assetion code in bug 28424. 
The reason is many of the internet search file contains copyright symbol in the 
comment section. The right thing to do is to fix the code itself. But for now, 
it is helpful to replace those copyright symbol to "(c)" so I won't hit that 
many assertion. Here is the patch

Index: datasets/AOLSearch.src
===================================================================
RCS file: /m/pub/mozilla/xpfe/components/search/datasets/AOLSearch.src,v
retrieving revision 1.2
diff -r1.2 AOLSearch.src
1c1
< # Copyright ©1998-1999 America Online, Inc.
---
> # Copyright (c)1998-1999 America Online, Inc.
Index: datasets/Netscape_Business.src
===================================================================
RCS file: /m/pub/mozilla/xpfe/components/search/datasets/Netscape_Business.src,v
retrieving revision 1.3
diff -r1.3 Netscape_Business.src
2c2
< # Copyright ©1999 Netscape Communications Corp.
---
> # Copyright (c)1999 Netscape Communications Corp.
Index: datasets/Netscape_Computing.src
===================================================================
RCS file: 
/m/pub/mozilla/xpfe/components/search/datasets/Netscape_Computing.src,v
retrieving revision 1.3
diff -r1.3 Netscape_Computing.src
2c2
< # Copyright ©1999 Netscape Communications Corp.
---
> # Copyright (c)1999 Netscape Communications Corp.
Index: datasets/Netscape_Entertainment.src
===================================================================
RCS file: 
/m/pub/mozilla/xpfe/components/search/datasets/Netscape_Entertainment.src,v
retrieving revision 1.3
diff -r1.3 Netscape_Entertainment.src
2c2
< # Copyright ©1999 Netscape Communications Corp.
---
> # Copyright (c)1999 Netscape Communications Corp.
Index: datasets/Netscape_Games.src
===================================================================
RCS file: /m/pub/mozilla/xpfe/components/search/datasets/Netscape_Games.src,v
retrieving revision 1.3
diff -r1.3 Netscape_Games.src
2c2
< # Copyright ©1999 Netscape Communications Corp.
---
> # Copyright (c)1999 Netscape Communications Corp.
Index: datasets/Netscape_Health.src
===================================================================
RCS file: /m/pub/mozilla/xpfe/components/search/datasets/Netscape_Health.src,v
retrieving revision 1.3
diff -r1.3 Netscape_Health.src
2c2
< # Copyright ©1999 Netscape Communications Corp.
---
> # Copyright (c)1999 Netscape Communications Corp.
Index: datasets/Netscape_Music.src
===================================================================
RCS file: /m/pub/mozilla/xpfe/components/search/datasets/Netscape_Music.src,v
retrieving revision 1.3
diff -r1.3 Netscape_Music.src
2c2
< # Copyright ©1999 Netscape Communications Corp.
---
> # Copyright (c)1999 Netscape Communications Corp.
Index: datasets/Netscape_Open_Directory.src
===================================================================
RCS file: 
/m/pub/mozilla/xpfe/components/search/datasets/Netscape_Open_Directory.src,v
retrieving revision 1.5
diff -r1.5 Netscape_Open_Directory.src
2c2
< # Copyright ©1999 Netscape Communications Corp.
---
> # Copyright (c)1999 Netscape Communications Corp.
Index: datasets/Netscape_Recreation.src
===================================================================
RCS file: 
/m/pub/mozilla/xpfe/components/search/datasets/Netscape_Recreation.src,v
retrieving revision 1.3
diff -r1.3 Netscape_Recreation.src
2c2
< # Copyright ©1999 Netscape Communications Corp.
---
> # Copyright (c)1999 Netscape Communications Corp.
Index: datasets/Netscape_Reference.src
===================================================================
RCS file: 
/m/pub/mozilla/xpfe/components/search/datasets/Netscape_Reference.src,v
retrieving revision 1.3
diff -r1.3 Netscape_Reference.src
2c2
< # Copyright ©1999 Netscape Communications Corp.
---
> # Copyright (c)1999 Netscape Communications Corp.
Index: datasets/Netscape_Regional.src
===================================================================
RCS file: /m/pub/mozilla/xpfe/components/search/datasets/Netscape_Regional.src,v
retrieving revision 1.3
diff -r1.3 Netscape_Regional.src
2c2
< # Copyright ©1999 Netscape Communications Corp.
---
> # Copyright (c)1999 Netscape Communications Corp.
Index: datasets/Netscape_Relationships.src
===================================================================
RCS file: 
/m/pub/mozilla/xpfe/components/search/datasets/Netscape_Relationships.src,v
retrieving revision 1.3
diff -r1.3 Netscape_Relationships.src
2c2
< # Copyright ©1999 Netscape Communications Corp.
---
> # Copyright (c)1999 Netscape Communications Corp.
Index: datasets/Netscape_Shopping.src
===================================================================
RCS file: /m/pub/mozilla/xpfe/components/search/datasets/Netscape_Shopping.src,v
retrieving revision 1.3
diff -r1.3 Netscape_Shopping.src
2c2
< # Copyright ©1999 Netscape Communications Corp.
---
> # Copyright (c)1999 Netscape Communications Corp.
Index: datasets/Netscape_Society.src
===================================================================
RCS file: /m/pub/mozilla/xpfe/components/search/datasets/Netscape_Society.src,v
retrieving revision 1.3
diff -r1.3 Netscape_Society.src
2c2
< # Copyright ©1999 Netscape Communications Corp.
---
> # Copyright (c)1999 Netscape Communications Corp.
Index: datasets/Netscape_Sports.src
===================================================================
RCS file: /m/pub/mozilla/xpfe/components/search/datasets/Netscape_Sports.src,v
retrieving revision 1.3
diff -r1.3 Netscape_Sports.src
2c2
< # Copyright ©1999 Netscape Communications Corp.
---
> # Copyright (c)1999 Netscape Communications Corp.
Index: datasets/Netscape_Travel.src
===================================================================
RCS file: /m/pub/mozilla/xpfe/components/search/datasets/Netscape_Travel.src,v
retrieving revision 1.3
diff -r1.3 Netscape_Travel.src
2c2
< # Copyright ©1999 Netscape Communications Corp.
---
> # Copyright (c)1999 Netscape Communications Corp.
Index: datasets/Netscape_World.src
===================================================================
RCS file: /m/pub/mozilla/xpfe/components/search/datasets/Netscape_World.src,v
retrieving revision 1.3
diff -r1.3 Netscape_World.src
2c2
< # Copyright ©1999 Netscape Communications Corp.
---
> # Copyright (c)1999 Netscape Communications Corp.

Here is rjc's comment after review this

Hi Frank, 

Just changing the copyright character to instead be "(c)" is fine with me... if 
you can get
approval, feel free to check in.
add beta1 to the keyword since we need to make it PDT+ to check in these 
days.... Just follow the rule ....
Status: NEW → ASSIGNED
Keywords: beta1
Target Milestone: M15
This is nominated for Beta1 to make it easier to find other bugs.
Very safe -- just changing comments.

The sherlock search files contain non-ASCII copyright symbols in comments
which generates nsString asserts.  This creates a lot of assertion noise
when trying to find other nsString misusages. (Bug 28424 has been filed
against the nsString misusage by search which causes these asserts.)

Bug 29516 is a workaround for bug 28424. By changing the copyright symbol to
"(c)" in the sherlock search (.src) files, the asserts are eliminated.
Putting on PDT+ radar for beta1.
Whiteboard: [PDT+]
PLEASE!!!  Check in fix by today or tomorrow!!
Whiteboard: [PDT+] → [PDT+] ETA 2/28
fix and check in
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
marking VERIFIED
Status: RESOLVED → VERIFIED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.