295212 - internally rename unifinders' column "filename" to "calendarname" [trunk]

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: trunk

The unifinder (and unifinder todo) column internally named "filename" should
instead be named "calendarname".  (mvl requested this at bug 295164 comment 2. 
I guess because it is a user-editable display name, not a filename recognized by
the OS).

Reproducible: Always

Steps to Reproduce:
1. See code at
http://lxr.mozilla.org/mozilla/source/calendar/resources/content/calendar.xul#687
2.
3.

Actual Results:  
column is internally named unifinder-search-results-tree-col-filename with label
&calendar.unifinder.tree.filename.label;

Expected Results:  
column is internally named unifinder-search-results-tree-col-calendarname with
label &calendar.unifinder.tree.calendarname.label;

Comment 1

[gekacheka]

please apply this fix after bug 295164, bug 278621, bug 295168 to avoid
invalidating those patches.

Comment 2

[gekacheka]

Attachment: rename unfinders' column "filename" to "calendarname" in tree code and locales

(patch -l -p 2 -i file.patch)
(Please apply after bug 278621, bug 295164, and bug 295168)

renames 
-  unifinder-todo-tree-col-filename
+  unifinder-todo-tree-col-calendarname

- unifinder-search-results-tree-col-filename
+ unifinder-search-results-tree-col-calendarname

- &calendar.unifinder.tree.filename.label;
+ &calendar.unifinder.tree.calendarname.label;

Testing:  calendar name column and sorting still work.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

I don't see why you introduce a filename column in bug 295168, and then rename
it here. Why not give it the right name when you introduce it, so in bug 295168?

Comment 4

[gekacheka]

I'm trying to save work updating the previously submitted patches for the other
bugs.

The unifinder and calendar.dtd already used the "&...filename;" name, so I was
being consistent with that in those previous patches.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in.