295213 - whine mail still goes out even though whinedays = "0"

Status: RESOLVED FIXED

(Bugzilla :: Whining, defect)

Description

[Gabriel Hernandez]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1)
Build Identifier: Bugzilla 2.18

We have currently enabled the whine mail feature in our internal installation 
of Bugzilla 2.18.  According to the parameters documentation (here: 
http://www.bugzilla.org/docs/2.18/html/parameters.html), I should be able to 
disable the "whining" at will through the parameters page by setting the 
whinedays value to "0".  When set to "0" (without the quotes), the whine mails 
are sent out on a daily basis.

Is this an error in the documentation or should the whineatnews.pl script be 
updated?

Thanks in advance for any help.

Reproducible: Always

Steps to Reproduce:
1.Enable a cron tab entry for whineatnews.pl on a daily schedule
2.Set the whine days value on the parameters page to "0" (no quotes)

Actual Results:  
Whining still sends out on a daily basis.

Expected Results:  
whineatnews.pl should end with no action if whinedays is "0"

Comment 1

[Marc Schumann [:Wurblzap]]

The description of the whinedays parameter says "The number of days that we'll
let a bug sit untouched in a NEW state before our cronjob will whine at the owner".

So -- if you set it to 0, it'll let a bug sit 0 days in a NEW state before the
cronjob whines at the owner. As a result, it'll whine every cron run (i.e.
probably daily).

If you want to effectively disable whining, set the parameter to a very high value.

Comment 2

[Marc Schumann [:Wurblzap]]

Reopening -- sorry, you're talking about docs while I looked at the parameter
description. Docs should be consistent with behaviour. I'm fine with either
changing docs or code -- both sounds sensible to me.

Comment 3

[Marc Schumann [:Wurblzap]]

Attachment: HEAD patch

Comment 4

[Marc Schumann [:Wurblzap]]

Attachment: Branch patch

Comment 5

[Gabriel Hernandez]

Thanks for the patches.  I will test at the next available opportunity and 
reply with the results

Comment 6

[Gabriel Hernandez]

We have implanted the attached patches and they work as expected.

Thank you, wurblzap.

Comment 7

[Frédéric Buclin]

Comment on attachment 184309 [details] [diff] [review]
HEAD patch

r=LpSolit

Comment 8

[Frédéric Buclin]

Comment on attachment 184310 [details] [diff] [review]
Branch patch

r=LpSolit

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Good low-risk polish fix.

Comment 10

[Frédéric Buclin]

Tip:

Checking in defparams.pl;
/cvsroot/mozilla/webtools/bugzilla/defparams.pl,v  <--  defparams.pl
new revision: 1.158; previous revision: 1.157
done
Checking in whineatnews.pl;
/cvsroot/mozilla/webtools/bugzilla/whineatnews.pl,v  <--  whineatnews.pl
new revision: 1.18; previous revision: 1.17
done


2.18.1:

Checking in defparams.pl;
/cvsroot/mozilla/webtools/bugzilla/defparams.pl,v  <--  defparams.pl
new revision: 1.128.2.4; previous revision: 1.128.2.3
done
Checking in whineatnews.pl;
/cvsroot/mozilla/webtools/bugzilla/whineatnews.pl,v  <--  whineatnews.pl
new revision: 1.14.2.3; previous revision: 1.14.2.2
done