295215 - Adblock crashes Firefox when trying to overlay flash [@ GetScopeOfObject 1b738c06 ]

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Adam Kowalczyk]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050523 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050523 Firefox/1.0+

Adblock crashes Firefox when using its "overlay flash" function (Tools > Adblock
> Overlay Flash (for left-click) ). Happens on all the sites, regardless they
actually contain any flash to overlay.

Reproducible: Always

Steps to Reproduce:
1. Go Tools > Adblock > Overlay Flash (for left-click)



Actual Results:  
Crash.

Expected Results:  
Adblock overlays all flash objects in the page with a clickable box or does
nothing when page doesn't contain flash.

Using clean profile.
Adblock 0.5.2.039 (hacked trunk version from
http://www.projects1.com/firefox/exthacks/FFnightlyextensions.html also crashes).
Talkback ID: 6059143

Comment 1

[Jaime Mitchell (use [e-mail] for email)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050523
Firefox/1.0+ ID:2005052301

Confirmed using U.M.O version of Adblock.

Comment 2

[Dave Townsend [:mossop]]

This is not a problem with:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050520
Firefox/1.0+ ID:2005052015

Comment 3

[Jaime Mitchell (use [e-mail] for email)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050519
Firefox/1.0+ ID:2005051915

WFM

-> Possible fallout from bug 281988 ?

Comment 4

[Ben Fowler]

I may be getting a bit too far ahead here: but do you have a test case?

See 
Bug 281657 "Crash with this testcase (derived from Adblock+Flashblock crash case) 
[@ nsBlockFrame::PullFrameFrom]"

Comment 5

[Ria Klaassen (not reading all bugmail)]

Saw the first crash in the nightly of 21-May: ID:2005052122.

Comment 6

[Jaime Mitchell (use [e-mail] for email)]

(In reply to comment #4)
> I may be getting a bit too far ahead here: but do you have a test case?
> 

Tools > Adblock > Overlay Flash (for left-click) on this page crashes 

bug 281657 appears to a different issue to this bug as this is a recent regression

Comment 7

[Peter van der Woude [:Peter6]]

talkback
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=TB6060115E

Comment 8

[Jaime Mitchell (use [e-mail] for email)]

Bug 295195 (Spellbound extension) appears to be a simular (if not the same) issue?

Comment 9

[Boris Zbarsky [:bzbarsky]]

Probably the same as bug 295101

Comment 10

[Boris Zbarsky [:bzbarsky]]

Fixed by patch in bug 295101.