In bug 255769 we reorganized the table of keyboard shortcuts used in Firefox into categories. In the process we discovered just how hideous the reorganization would make the table look. This is a fault of the default stylesheet provided with the Help Viewer, and it needs to be fixed. A little style love here will be much appreciated by anyone who needs to look at Firefox's shortcuts documentation. To see the garishness, either download a nightly built sometime after right now or wait until I get around to posting a screenshot, which may take some time (real life intrudes, at the least for the next week or so). Then visit Shortcuts in Firefox Help and writhe in pain.
I can take a shot at this. I took a quick look at skin/classic/help.css in classic.jar, but don't see the current table styles right off hand. Can someone point me to the right spot? Thanks.
Assignee: nobody → steven
Target Milestone: --- → mozilla1.8beta3
Created attachment 195140 [details] [diff] [review] Minor prettying-up of the tables in the shortcuts help This patch lightens up the colors in the table a bit, makes the borders less obtrusive, and gets rid of that nasty aqua color. Here's a screenshot of it in action: http://actsofvolition.com/images/screenshots/firefox/firefox-shortcuts-help.png There is also some indenting inconsistency in this file (some lines are indented with a tab, others with two spaces) - I didn't clean it up in this patch, it should probably be done in a separate whitespace cleanup patch.
can you post a screenshot please?
Comment on attachment 199169 [details] [diff] [review] Patch against CVS looks good
Attachment #199169 - Flags: first-review?(steven) → first-review+
Created attachment 199455 [details] Screenshot Here's a screenshot with the patch applied (and with another, unrelated patch that changes the contents of the shortcuts documentation). There's a part of me that thinks that 6px padding is too much, but running with it for a while has made it less jarring, and I don't mind it any more.
Comment on attachment 199169 [details] [diff] [review] Patch against CVS This change should only affect how content in Firefox Help is displayed; there shouldn't be any risk in this patch.
Attachment #199169 - Flags: approval1.8rc1?
Attachment #199169 - Flags: approval1.8rc1? → approval1.8rc1+
Patch checked in on branch and trunk.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.8beta3 → mozilla1.8rc1
You need to log in before you can comment on or make changes to this bug.